From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: raman Newsgroups: gmane.emacs.devel Subject: Re: Brittleness of called-interactively-p Date: Fri, 17 Jul 2015 11:10:13 -0700 Message-ID: References: <871tgeufzt.fsf@gmail.com> <87r3odtngi.fsf@gmail.com> <87380st7c1.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1437156657 5658 80.91.229.3 (17 Jul 2015 18:10:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 17 Jul 2015 18:10:57 +0000 (UTC) Cc: Dmitri Paduchikh , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 17 20:10:56 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZGA64-00076X-0B for ged-emacs-devel@m.gmane.org; Fri, 17 Jul 2015 20:10:56 +0200 Original-Received: from localhost ([::1]:45876 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZGA63-0000gr-CR for ged-emacs-devel@m.gmane.org; Fri, 17 Jul 2015 14:10:55 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36068) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZGA5a-0000aB-UZ for emacs-devel@gnu.org; Fri, 17 Jul 2015 14:10:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZGA5U-0004mp-VI for emacs-devel@gnu.org; Fri, 17 Jul 2015 14:10:26 -0400 Original-Received: from mail-pa0-x22a.google.com ([2607:f8b0:400e:c03::22a]:33304) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZGA5U-0004m8-OL for emacs-devel@gnu.org; Fri, 17 Jul 2015 14:10:20 -0400 Original-Received: by padck2 with SMTP id ck2so64259470pad.0 for ; Fri, 17 Jul 2015 11:10:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=75NWlrSfUtJrVCjuImyUhJWMvDAcVT0ZFozand2wbwU=; b=K9arHRvk1WEOOCLh7lWXtNq9yvIagOzp9LTgZTmUhY0sRVrsduHY5NwFsXtHVcL0sV vKv3i6CsOU9JOcAJik7w9Z4l/KL7HYrvtMtLKyNkXUHlQJfsv7k7D+riIdzqRL+yvs3U djzO4YnkXA2yotaQ1APzWpw8n2ljrcT3KeT+ZL/YUi/p4j9ss8boAH5FfeJgN0OJV/RQ SYmySAaoJByQ4k7Sj3UeZ+LmE6z5vf5o4aZps2futofmDxJNOoaBamvBiZkyfzHE3Q1N vO/o6tR+dckzs4432myeJ/ty4WqPv73gw4APvJy6rcOHWC4bAorh+VfikvcRdW99mTQa o4tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=75NWlrSfUtJrVCjuImyUhJWMvDAcVT0ZFozand2wbwU=; b=F4a8iSV0XVuOPnOIfBbYbMQFIStbjT9fS/y3Wk52mkzDTOs1aya4kU2lTxMt80PW85 uVVkJ/cfBib6y+xhAf5EzYV101qganzpt+GLkoi4dv4PmPZ1Xz32qfHLHeSbhrxw66qN KbqK4qUFW8uSAup54YtjT1/PvHDzKQjt6S9Eih2R5NqQjHV+iU9eRvIQcwjjuBUt076f JhnW6YNbz2LzbE8Knz1GrDYsyfmCGyGZmpNdoJAATGlo6XQT3umpRQk3+OlPx7f2WV+E bRBFZ2EBhIn+oDflivUuY9d7ohF5fQTdk981D4/xwf55n8i2iuh3KGBicf9OkxCl7mv8 dv9Q== X-Gm-Message-State: ALoCoQkeb4R3G+13uEyysBZ2hvf4HowYUi7IFkywMyufF2hPAvhSZ5hMukmup2/WxXt+Migt+0XZ X-Received: by 10.66.132.16 with SMTP id oq16mr8680472pab.13.1437156618928; Fri, 17 Jul 2015 11:10:18 -0700 (PDT) Original-Received: from raman-glaptop2 (c-73-170-121-60.hsd1.ca.comcast.net. [73.170.121.60]) by smtp.gmail.com with ESMTPSA id km11sm11895890pbd.61.2015.07.17.11.10.14 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 17 Jul 2015 11:10:15 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Thu, 16 Jul 2015 18:55:29 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c03::22a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:187932 Archived-At: Hi Stefan, You're right that the two transitions -- called-interactively-p and nadvice happened at around the same time. However emacspeak still uses advice.el, not nadvice.el. I dont quite remember the error pattern that caused me to create the implementation of ems-interactive-p that I posted, but there was definitely a bizarre error that things like ruby-mode triggered. Trying to reconstruct from memory: Certain edit actions in ruby-mode called backward-sexp (non-interactively of course).. The spoken feedback emacspeak generated on those edit actions also relied on calling backward-sexp (again, non-interactively) to compute what to speak. Somewhere in all of that, I got an error from one of the new advice related functions -- --