From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.devel Subject: Re: MPS: weak hash tables Date: Sat, 06 Jul 2024 16:56:39 +0000 Message-ID: References: <87msmu1uy5.fsf@gmail.com> <87cynq1sx0.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_hm6km4PVF8XmTl1WSxTboXC15EmT4aQ15YtFf6wyk6E" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16609"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Helmut Eller , Eli Zaretskii , emacs-devel@gnu.org To: =?utf-8?Q?Gerd_M=C3=B6llmann?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jul 06 19:16:46 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sQ91i-00049c-B4 for ged-emacs-devel@m.gmane-mx.org; Sat, 06 Jul 2024 19:16:46 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sQ91F-0007kM-Fu; Sat, 06 Jul 2024 13:16:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQ8iQ-0001vl-TF for emacs-devel@gnu.org; Sat, 06 Jul 2024 12:56:50 -0400 Original-Received: from mail-40133.protonmail.ch ([185.70.40.133]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQ8iO-0001o7-OR for emacs-devel@gnu.org; Sat, 06 Jul 2024 12:56:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1720285006; x=1720544206; bh=Y637AXGADCFOXJU41ta6Pz6x5cZqqi9FdI+YYKPrezk=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=xLc72E3cjGWJNp/wBXO2F5V12q3aBI02p/tOYjMOKWiuvgLbJfKFAAhoKXAaMp1bW Wd1lGGMnwKU3PHrjYJR1x2OrFtsBA2dY1b3H2WVOKi23UiTqnRDUgLEFdcOVIAky+Z aAkxZ0/hxKp0wEXqMeeszfwARH2V1dxgL8TpXAMUOw7hyHNYh9rgw/fdn5/aCPQLRO aXk0usZlqyYRAjdFxoNXLw6V1VWHGFAtPlxCHqtkC4Q53keQwDYhckevSDLhIRCOXp kIwwkbowNwF92xhxgYaBozQk3Fn0eAE6MKjULJ8SGo4uix5CSZbNz0qNNLFcbrnLVe 9FYJjTJTeOr9Q== In-Reply-To: Feedback-ID: 112775352:user:proton X-Pm-Message-ID: 27060d672b6399e91ee1543333a0a2ddcdf4dda5 Received-SPF: pass client-ip=185.70.40.133; envelope-from=pipcet@protonmail.com; helo=mail-40133.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sat, 06 Jul 2024 13:16:15 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321449 Archived-At: This is a multi-part message in MIME format. --b1_hm6km4PVF8XmTl1WSxTboXC15EmT4aQ15YtFf6wyk6E Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Saturday, July 6th, 2024 at 16:31, Gerd M=C3=B6llmann wrote: > Pip Cet pipcet@protonmail.com writes: >=20 > > I wonder how representative that is of actual workloads, though. >=20 > It isn't, for sure :-). >=20 > > It does appear mostly to be the cost of finalization, if I deactivate > > that (and leak the memory instead!) it takes about 6.5 seconds on this > > machine compared to ~9 on my main Emacs. Totally unscientific, of > > course, I'm pretty sure I even updated my compiler since compiling > > vanilla Emacs. Both use nativecomp. >=20 > I think the same. I under the impression that probably many millions of > bignums are used, each of which requires inter-thread communication and > so on. That's quite expensive if true. >=20 > > So IF it's worth optimizing this, the thing to look into would be to > > use MPS-managed memory for GMP bignums, so we don't need a finalizer > > at all. I think that's quite easy to do, but requires violating the > > GMP API by accessing internal member fields directly. >=20 >=20 > We have already this in bignum.c >=20 > mp_set_memory_functions (xmalloc, xrealloc_for_gmp, xfree_for_gmp); >=20 > Haven't read the GMP docs yet, but that looks like something that could > be used. Patch attached, couldn't resist :-) Memory usage is perfectly acceptable with this patch, but it does do a lot = of GC. > > I believe Eli is right, though, that we should deviate from what Emacs > > usually does as little as possible until we've got things working. > > That means just keeping track of how much we've allocated and calling > > garbage_collect via maybe_garbage_collect, I think. > Can you explain? I mean I agree in general, but in this case I'm not so > sure. What I've currently implemented is basically a function of the > number of allocated finalizable objects and only finalizable objects pay > the price. The size of allocated memory overall, i.e. counting the bytes > in alloc_impl doesn't contain the information. But it's probably a better indicator of how much GC activity happened, and = that influences how many finalization messages there would be, assuming tha= t an approximately constant percentage of objects is finalizable... Pip --b1_hm6km4PVF8XmTl1WSxTboXC15EmT4aQ15YtFf6wyk6E Content-Type: text/x-patch; name=0002-mps-bignums.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0002-mps-bignums.patch ZGlmZiAtLWdpdCBhL3NyYy9iaWdudW0uYyBiL3NyYy9iaWdudW0uYwppbmRleCAxZmUxOTVkNzhl YS4uMzMwZmRmNDMyNGMgMTAwNjQ0Ci0tLSBhL3NyYy9iaWdudW0uYworKysgYi9zcmMvYmlnbnVt LmMKQEAgLTIwLDEyICsyMCwxMyBAQAogI2luY2x1ZGUgPGNvbmZpZy5oPgogCiAjaW5jbHVkZSAi YmlnbnVtLmgiCi0KICNpbmNsdWRlICJsaXNwLmgiCiAKICNpbmNsdWRlIDxtYXRoLmg+CiAjaW5j bHVkZSA8c3RkbGliLmg+CiAKKyNpbmNsdWRlICJpZ2MuaCIKKwogLyogbXB6IGdsb2JhbCB0ZW1w b3Jhcmllcy4gIE1ha2luZyB0aGVtIGdsb2JhbCBzYXZlcyB0aGUgdHJvdWJsZSBvZgogICAgcHJv cGVybHkgdXNpbmcgbXB6X2luaXQgYW5kIG1wel9jbGVhciBvbiB0ZW1wb3JhcmllcyBldmVuIHdo ZW4KICAgIHN0b3JhZ2UgaXMgZXhoYXVzdGVkLiAgQWRtaXR0ZWRseSB0aGlzIGlzIG5vdCBpZGVh bC4gIEFuIG1weiB2YWx1ZQpAQCAtMzQsMTggKzM1LDI5IEBACiAgICByb3VuZGRpdl9xIGFuZCBy b3VuZGluZ19kcml2ZXIgYm90aCBuZWVkIGZvdXIgYW5kIHRpbWVfYXJpdGggbmVlZHMKICAgIGZp dmUuICAqLwogCi1tcHpfdCBtcHpbNV07CittcHpfdCBtcHpbNV0gPSB7IDAsIH07CisKK3N0YXRp YyB2b2lkICoKK3htYWxsb2NfZm9yX2dtcCAoc2l6ZV90IHNpemUpCit7CisgIHJldHVybiBpZ2Nf YWxsb2NfYnl0ZXMgKHNpemUpOworfQogCiBzdGF0aWMgdm9pZCAqCiB4cmVhbGxvY19mb3JfZ21w ICh2b2lkICpwdHIsIHNpemVfdCBpZ25vcmUsIHNpemVfdCBzaXplKQogewotICByZXR1cm4geHJl YWxsb2MgKHB0ciwgc2l6ZSk7CisgIGlmIChzaXplID4gaWdub3JlKQorICAgIHsKKyAgICAgIHZv aWQgKnJldCA9IHhtYWxsb2NfZm9yX2dtcCAoc2l6ZSk7CisgICAgICBtZW1jcHkgKHJldCwgcHRy LCBpZ25vcmUpOworICAgICAgcmV0dXJuIHJldDsKKyAgICB9CisgIHJldHVybiBwdHI7CiB9CiAK IHN0YXRpYyB2b2lkCiB4ZnJlZV9mb3JfZ21wICh2b2lkICpwdHIsIHNpemVfdCBpZ25vcmUpCiB7 Ci0gIHhmcmVlIChwdHIpOwogfQogCiB2b2lkCkBAIC02Miw4ICs3NCwxMCBAQCBpbml0X2JpZ251 bSAodm9pZCkKICAgICAgcHJvZ3JhbSBleGVjdXRpb24uICBBICdsb25nam1wJyBvciB0aHJvd2lu ZyBhIEMrKyBleGNlcHRpb24gd2lsbAogICAgICBoYXZlIHVuZGVmaW5lZCByZXN1bHRzLiIgIEJ1 dCB4bWFsbG9jIGFuZCB4cmVhbGxvYyBkbyBjYWxsCiAgICAgICdsb25nam1wJy4gICovCi0gIG1w X3NldF9tZW1vcnlfZnVuY3Rpb25zICh4bWFsbG9jLCB4cmVhbGxvY19mb3JfZ21wLCB4ZnJlZV9m b3JfZ21wKTsKKyAgbXBfc2V0X21lbW9yeV9mdW5jdGlvbnMgKHhtYWxsb2NfZm9yX2dtcCwgeHJl YWxsb2NfZm9yX2dtcCwgeGZyZWVfZm9yX2dtcCk7CiAKKyAgZm9yIChpbnQgaSA9IDA7IGkgPCBB UlJBWUVMVFMgKG1weik7IGkrKykKKyAgICBpZ2Nfcm9vdF9jcmVhdGVfZXhhY3RfcHRyICgmbXB6 W2ldWzBdLl9tcF9kKTsKICAgZm9yIChpbnQgaSA9IDA7IGkgPCBBUlJBWUVMVFMgKG1weik7IGkr KykKICAgICBtcHpfaW5pdCAobXB6W2ldKTsKIH0KZGlmZiAtLWdpdCBhL3NyYy9pZ2MuYyBiL3Ny Yy9pZ2MuYwppbmRleCBjY2ZhMTM2ZDI1OC4uZjJmYTMyNzA3NjUgMTAwNjQ0Ci0tLSBhL3NyYy9p Z2MuYworKysgYi9zcmMvaWdjLmMKQEAgLTIxNzAsNiArMjE3MCwxOSBAQCBmaXhfbWFya2VyICht cHNfc3NfdCBzcywgc3RydWN0IExpc3BfTWFya2VyICptKQogICByZXR1cm4gTVBTX1JFU19PSzsK IH0KIAorc3RhdGljIG1wc19yZXNfdAorZml4X2JpZ251bSAobXBzX3NzX3Qgc3MsIHN0cnVjdCBM aXNwX0JpZ251bSAqbSkKK3sKKyAgTVBTX1NDQU5fQkVHSU4gKHNzKQorICB7CisgICAgbXBzX2Fk ZHJfdCByZWYgPSBtLT52YWx1ZVswXS5fbXBfZDsKKyAgICBJR0NfRklYMTJfUkFXIChzcywgJnJl Zik7CisgICAgbS0+dmFsdWVbMF0uX21wX2QgPSByZWY7CisgIH0KKyAgTVBTX1NDQU5fRU5EIChz cyk7CisgIHJldHVybiBNUFNfUkVTX09LOworfQorCiBzdGF0aWMgbXBzX3Jlc190CiBmaXhfZmlu YWxpemVyIChtcHNfc3NfdCBzcywgc3RydWN0IExpc3BfRmluYWxpemVyICpmKQogewpAQCAtMjM3 NSw2ICsyMzg4LDcgQEAgZml4X3ZlY3RvciAobXBzX3NzX3Qgc3MsIHN0cnVjdCBMaXNwX1ZlY3Rv ciAqdikKIAlicmVhazsKIAogICAgICAgY2FzZSBQVkVDX0JJR05VTToKKwlJR0NfRklYX0NBTExf Rk4gKHNzLCBzdHJ1Y3QgTGlzcF9CaWdudW0sIHYsIGZpeF9iaWdudW0pOwogCWJyZWFrOwogCiAg ICAgICBjYXNlIFBWRUNfTkFUSVZFX0NPTVBfVU5JVDoKQEAgLTMxOTUsNyArMzIwOSw2IEBAIG1h eWJlX2ZpbmFsaXplIChtcHNfYWRkcl90IGNsaWVudCwgZW51bSBwdmVjX3R5cGUgdGFnKQogICBt cHNfYWRkcl90IHJlZiA9IGNsaWVudF90b19iYXNlIChjbGllbnQpOwogICBzd2l0Y2ggKHRhZykK ICAgICB7Ci0gICAgY2FzZSBQVkVDX0JJR05VTToKICAgICBjYXNlIFBWRUNfRk9OVDoKICAgICBj YXNlIFBWRUNfVEhSRUFEOgogICAgIGNhc2UgUFZFQ19NVVRFWDoKQEAgLTMyMTAsNiArMzIyMyw3 IEBAIG1heWJlX2ZpbmFsaXplIChtcHNfYWRkcl90IGNsaWVudCwgZW51bSBwdmVjX3R5cGUgdGFn KQogICAgICAgbXBzX2ZpbmFsaXplIChnbG9iYWxfaWdjLT5hcmVuYSwgJnJlZik7CiAgICAgICBi cmVhazsKIAorICAgIGNhc2UgUFZFQ19CSUdOVU06CiAjaWZuZGVmIElOX01ZX0ZPUksKICAgICBj YXNlIFBWRUNfT0JBUlJBWToKICNlbmRpZgo= --b1_hm6km4PVF8XmTl1WSxTboXC15EmT4aQ15YtFf6wyk6E--