Re: memory corruption in regex.c

[Alexandre Oliva <aoliva@redhat.com>]

On Mar 22, 2008, Chong Yidong <cyd@stupidchicken.com> wrote:

>> -    re_char *old_buffer = bufp->buffer;					\
>> +    unsigned char *old_buffer = bufp->buffer;				\

> What is the purpose of this?

Compiler warning avoidance.  b is unsigned char *, whereas re_char is
const unsigned char *.  I suppose it would be enough for new_buffer to
be non-const, but these buffers are not const anyway, and the
constness doesn't buy much at this point.

-- 
Alexandre Oliva         http://www.lsd.ic.unicamp.br/~oliva/
FSF Latin America Board Member         http://www.fsfla.org/
Red Hat Compiler Engineer   aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist  oliva@{lsd.ic.unicamp.br, gnu.org}