From mboxrd@z Thu Jan 1 00:00:00 1970 Path: quimby.gnus.org!not-for-mail From: pinard@iro.umontreal.ca (=?iso-8859-1?q?Fran=E7ois?= Pinard) Newsgroups: gmane.emacs.devel Subject: Re: Crash on loading image Date: 14 Feb 2002 21:14:29 -0500 Message-ID: References: NNTP-Posting-Host: quimby2.netfonds.no Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: quimby2.netfonds.no 1013740051 9396 195.204.10.66 (15 Feb 2002 02:27:31 GMT) X-Complaints-To: usenet@quimby2.netfonds.no NNTP-Posting-Date: 15 Feb 2002 02:27:31 GMT Cc: emacs-devel@gnu.org, emacs-pretest-bug@gnu.org Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby2.netfonds.no with esmtp (Exim 3.12 #1 (Debian)) id 16bY5y-0002RS-00 for ; Fri, 15 Feb 2002 03:27:31 +0100 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.33 #1 (Debian)) id 16bXu9-00060d-00; Thu, 14 Feb 2002 21:15:17 -0500 Original-Received: from machine.sram.qc.ca ([207.35.30.100] helo=rd.sram.qc.ca) by fencepost.gnu.org with smtp (Exim 3.33 #1 (Debian)) id 16bXtU-0005xl-00; Thu, 14 Feb 2002 21:14:36 -0500 Original-Received: from carouge.sram.qc.ca.progiciels-bpi.ca (carouge.sram.qc.ca [207.35.30.105]) by rd.sram.qc.ca (Postfix) with ESMTP id B6B921C7B3; Thu, 14 Feb 2002 21:14:51 -0500 (EST) Original-To: Pavel@Janik.cz (Pavel =?iso-8859-2?q?Jan=EDk?=) X-Face: "b_m|CE6#'Q8fliQrwHl9K,]PA_o'*S~Dva{~b1n*)K*A(BIwQW.:LY?t4~xhYka_.LV?Qq `}X|71X0ea&H]9Dsk!`kxBXlG;q$mLfv_vtaHK_rHFKu]4'<*LWCyUe@ZcI6"*wB5M@[m Original-Lines: 35 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.1.90 Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.5 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: quimby.gnus.org gmane.emacs.devel:1154 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:1154 --=-=-= Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: quoted-printable [Pavel Jan=EDk] > can you please test this? I will provide ChangeLog entry later. > Too tired right now... =20 > --- xfns.c.~1.537.~ Tue Jan 22 16:16:44 2002 > +++ xfns.c Wed Feb 6 15:49:29 2002 > @@ -10161,8 +10161,8 @@ > return 0; > } >=20=20 > - width =3D img->width =3D gif->SWidth; > - height =3D img->height =3D gif->SHeight; > + width =3D img->width =3D max (gif->SWidth, gif->Image.Left + gif->Imag= e.Width); > + height =3D img->height =3D max(gif->SHeight, gif->Image.Top + gif->Ima= ge.Height); >=20=20 > /* Create the X image and pixmap. */ > if (!x_create_x_image_and_pixmap (f, width, height, 0, &ximg, &img->pi= xmap)) Pavel, I just installed 21.1.90 without the patch above, and Emacs vanishes whenever I open any of the two images you provided in your reply. I then installed the said patch over 21.1.90, and the image is now opened correctly in both cases. So the patch does repair something :-). Congratulations! I'm merely repeating the remainder of your comments for the other readers: > This will be needed in RC and in HEAD. I'm CCing emacs-devel because > we need to get more testing for this. If you would like to know why to > test this, just try the above recipe with attached pictures. I have > tested this on a package of about 1400 pictures and only one of them > (attached opensign.gif) had the same problem (we used Screen Width of GIF, > but it was to small) and thus we crashed. --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit -- François Pinard http://www.iro.umontreal.ca/~pinard --=-=-=-- _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://mail.gnu.org/mailman/listinfo/emacs-devel