Re: Crash on loading image

[pinard@iro.umontreal.ca (François Pinard)]

[-- Attachment #1: Type: text/plain, Size: 1446 bytes --]

[Pavel Janík]

> can you please test this?  I will provide ChangeLog entry later.
> Too tired right now...
 
> --- xfns.c.~1.537.~	Tue Jan 22 16:16:44 2002
> +++ xfns.c	Wed Feb  6 15:49:29 2002
> @@ -10161,8 +10161,8 @@
>        return 0;
>      }
>  
> -  width = img->width = gif->SWidth;
> -  height = img->height = gif->SHeight;
> +  width = img->width = max (gif->SWidth, gif->Image.Left + gif->Image.Width);
> +  height = img->height = max(gif->SHeight, gif->Image.Top + gif->Image.Height);
>  
>    /* Create the X image and pixmap.  */
>    if (!x_create_x_image_and_pixmap (f, width, height, 0, &ximg, &img->pixmap))

Pavel, I just installed 21.1.90 without the patch above, and Emacs vanishes
whenever I open any of the two images you provided in your reply.  I then
installed the said patch over 21.1.90, and the image is now opened correctly
in both cases.  So the patch does repair something :-).  Congratulations!

I'm merely repeating the remainder of your comments for the other readers:

> This will be needed in RC and in HEAD.  I'm CCing emacs-devel because
> we need to get more testing for this.  If you would like to know why to
> test this, just try the above recipe with attached pictures.  I have
> tested this on a package of about 1400 pictures and only one of them
> (attached opensign.gif) had the same problem (we used Screen Width of GIF,
> but it was to small) and thus we crashed.

[-- Attachment #2: Type: text/plain, Size: 59 bytes --]


-- 
François Pinard   http://www.iro.umontreal.ca/~pinard