From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Constantino Calancha" Newsgroups: gmane.emacs.bugs Subject: bug#21390: 24.5; Missing definition for predicate `buffer-or-string-p' Date: Wed, 02 Sep 2015 11:07:46 +0900 Message-ID: References: <4kwpwaf8jj.fsf@fencepost.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1441159522 19281 80.91.229.3 (2 Sep 2015 02:05:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 2 Sep 2015 02:05:22 +0000 (UTC) Cc: "21390@debbugs.gnu.org" <21390@debbugs.gnu.org> To: "Glenn Morris" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 02 04:05:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZWxQE-0004F3-Q9 for geb-bug-gnu-emacs@m.gmane.org; Wed, 02 Sep 2015 04:05:11 +0200 Original-Received: from localhost ([::1]:60353 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWxQE-0006B6-4R for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Sep 2015 22:05:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51381) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWxQA-00069V-8e for bug-gnu-emacs@gnu.org; Tue, 01 Sep 2015 22:05:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZWxQ7-0006rd-3P for bug-gnu-emacs@gnu.org; Tue, 01 Sep 2015 22:05:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53339) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWxQ7-0006rV-1E for bug-gnu-emacs@gnu.org; Tue, 01 Sep 2015 22:05:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZWxQ6-0007EW-NG for bug-gnu-emacs@gnu.org; Tue, 01 Sep 2015 22:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Constantino Calancha" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Sep 2015 02:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21390 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21390-submit@debbugs.gnu.org id=B21390.144115948627778 (code B ref 21390); Wed, 02 Sep 2015 02:05:02 +0000 Original-Received: (at 21390) by debbugs.gnu.org; 2 Sep 2015 02:04:46 +0000 Original-Received: from localhost ([127.0.0.1]:45549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZWxPq-0007Dx-93 for submit@debbugs.gnu.org; Tue, 01 Sep 2015 22:04:46 -0400 Original-Received: from mail-pa0-f48.google.com ([209.85.220.48]:35401) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZWxPo-0007Dp-2y for 21390@debbugs.gnu.org; Tue, 01 Sep 2015 22:04:44 -0400 Original-Received: by pacfv12 with SMTP id fv12so14880414pac.2 for <21390@debbugs.gnu.org>; Tue, 01 Sep 2015 19:04:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:to:subject:references:date:cc:mime-version :content-transfer-encoding:from:message-id:in-reply-to:user-agent; bh=8172bY/OUViTrr4Bvhmmx2qCl7pMsLMLgh+VFlCM5tI=; b=serZEOZBO8d49EdR+W64rRTzYMdBrMhB70tmtBfAIvRsOUV4I8IgVsIMtuZqWY6e5m rfL9LINx6J0wGx6to2/2YY9GTwA899d1/wiePwoKqKUjLN32kLnEnOe+guaNfrbfO5Wk pUmhkVHNQS9lWy9FLOitbmrClsbOmtZ02liXbkyt5MvAsP6NCB6xND05aSghq/UOcNH0 3qIDTwaqOotCllqI4rGbuv3opeBtN+a1FINLSG3KjdGgf/Nq+pikbALLh30USinaXIfQ 6rTw1Tw3db04OxBEgUksVZZRtdSVy6nAjpW0w7Ks+VmPeKd2mf1t4/otO0GUXaOZx9Jh sJTA== X-Received: by 10.68.57.143 with SMTP id i15mr11163331pbq.104.1441159483125; Tue, 01 Sep 2015 19:04:43 -0700 (PDT) Original-Received: from calancha-ilc.kek.jp (calancha-ilc.kek.jp. [130.87.234.234]) by smtp.gmail.com with ESMTPSA id ip7sm19570450pbc.68.2015.09.01.19.04.41 (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 01 Sep 2015 19:04:42 -0700 (PDT) In-Reply-To: <4kwpwaf8jj.fsf@fencepost.gnu.org> User-Agent: Opera Mail/12.16 (Linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:106076 Archived-At: Hi Glenn, i dont think is needed i just find more natural to be defined than not. Its also elegant. There are two files that may use that predicate: simple.el 2856: (not (or (bufferp output-buffer) (stringp output-buffer)))) 3118: (not (or (bufferp output-buffer) (stringp output-buffer))))) gnus-art.el: 2800: ((not (or (bufferp (car handle)) (stringp (car handle))))) On Wed, 02 Sep 2015 00:45:04 +0900, Glenn Morris wrote: > Tino Calancha wrote: > >> Predicate `buffer-or-string-p' is declared but definition is missing in: >> emacs-24.5/src/data.c > > I guess you are referring to the fact that src/data.c contains > > DEFSYM (Qbuffer_or_string_p, "buffer-or-string-p") > > This is used in CHECK_STRING_OR_BUFFER in textprop.c. > The simple presence of the DEFSYM is not by itself motivation for the > addition of a "buffer-or-string-p" predicate. > > If you think such a thing is needed, you need to eg show how many places > in the current lisp sources would use it. And then if added it needs to > be documented too.