all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Constantino Calancha" <f92capac@gmail.com>
To: "Glenn Morris" <rgm@gnu.org>
Cc: "21390@debbugs.gnu.org" <21390@debbugs.gnu.org>
Subject: bug#21390: 24.5; Missing definition for predicate `buffer-or-string-p'
Date: Wed, 02 Sep 2015 11:07:46 +0900	[thread overview]
Message-ID: <op.x4bb68dw32915k@calancha-ilc.kek.jp> (raw)
In-Reply-To: <4kwpwaf8jj.fsf@fencepost.gnu.org>

Hi Glenn,

i dont think is needed i just find more natural to be defined than not.
Its also elegant.

There are two files that may use that predicate:

simple.el
    2856:	       (not (or (bufferp output-buffer)  (stringp  
output-buffer))))
    3118:		 (not (or (bufferp output-buffer) (stringp output-buffer)))))

gnus-art.el:
    2800:	   ((not (or (bufferp (car handle)) (stringp (car handle)))))



On Wed, 02 Sep 2015 00:45:04 +0900, Glenn Morris <rgm@gnu.org> wrote:

> Tino Calancha wrote:
>
>> Predicate `buffer-or-string-p' is declared but definition is missing in:
>> emacs-24.5/src/data.c
>
> I guess you are referring to the fact that src/data.c contains
>
>   DEFSYM (Qbuffer_or_string_p, "buffer-or-string-p")
>
> This is used in CHECK_STRING_OR_BUFFER in textprop.c.
> The simple presence of the DEFSYM is not by itself motivation for the
> addition of a "buffer-or-string-p" predicate.
>
> If you think such a thing is needed, you need to eg show how many places
> in the current lisp sources would use it. And then if added it needs to
> be documented too.





  reply	other threads:[~2015-09-02  2:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-01  1:47 bug#21390: 24.5; Missing definition for predicate `buffer-or-string-p' Tino Calancha
2015-09-01  2:39 ` bug#21390: Corrected patch Tino Calancha
2015-09-01 15:45 ` bug#21390: 24.5; Missing definition for predicate `buffer-or-string-p' Glenn Morris
2015-09-02  2:07   ` Constantino Calancha [this message]
2017-05-18  4:06 ` Tino Calancha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=op.x4bb68dw32915k@calancha-ilc.kek.jp \
    --to=f92capac@gmail.com \
    --cc=21390@debbugs.gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.