From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#29955: 25.2; stale lock files can hang emacs --batch Date: Tue, 23 Jan 2018 20:59:37 -0500 Message-ID: References: <871sj73gkx.fsf@tethera.net> <3o607tv4gl.fsf@fencepost.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1516759216 31226 195.159.176.226 (24 Jan 2018 02:00:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 24 Jan 2018 02:00:16 +0000 (UTC) User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) To: 29955-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 24 03:00:12 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eeAM1-0006tM-MB for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Jan 2018 02:59:57 +0100 Original-Received: from localhost ([::1]:41362 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eeAO0-0005y7-Ex for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Jan 2018 21:02:00 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52965) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eeANW-0005tc-3a for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2018 21:01:55 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eeAN5-0007WR-O4 for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2018 21:01:30 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60510) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eeAN5-0007VS-CP for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2018 21:01:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eeAN4-0000IJ-TB for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2018 21:01:02 -0500 Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Jan 2018 02:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 29955 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 29955@debbugs.gnu.org, rgm@gnu.org, david@tethera.net Original-Received: via spool by 29955-done@debbugs.gnu.org id=D29955.151675920930121 (code D ref 29955); Wed, 24 Jan 2018 02:01:02 +0000 Original-Received: (at 29955-done) by debbugs.gnu.org; 24 Jan 2018 02:00:09 +0000 Original-Received: from localhost ([127.0.0.1]:40173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eeAMD-0007pT-ET for submit@debbugs.gnu.org; Tue, 23 Jan 2018 21:00:09 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:58559) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eeAMB-0007gq-W8 for 29955-done@debbugs.gnu.org; Tue, 23 Jan 2018 21:00:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eeALh-0004sR-U0 for 29955-done@debbugs.gnu.org; Tue, 23 Jan 2018 21:00:02 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39025) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eeALh-0004sM-O7 for 29955-done@debbugs.gnu.org; Tue, 23 Jan 2018 20:59:37 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1eeALh-00080l-3f; Tue, 23 Jan 2018 20:59:37 -0500 X-Spook: Fortezza interception Fort Hancock Ft. Bragg Waco, Texas X-Ran: bEHXFyxCwN0sxi[[??s]6c>#}6,'@;EqQb(R/DM5` (Glenn Morris's message of "Mon, 22 Jan 2018 18:50:02 -0500") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142459 Archived-At: Version: 27.1 I applied the following to master (though emacs-26 seems appropriate to me). Together with 28718c4, it should fix this issue. commit 109da68 Date: Tue Jan 23 20:55:09 2018 -0500 Avoid kill-emacs-hook errors hanging batch mode * src/emacs.c (Fkill_emacs): Prevent errors from kill-emacs-hook hanging Emacs in batch mode. (Bug#29955) diff --git a/src/emacs.c b/src/emacs.c index 84cd3ac..8ea61b7 100644 --- a/src/emacs.c +++ b/src/emacs.c @@ -2024,7 +2024,10 @@ all of which are called before Emacs is actually killed. */ /* Fsignal calls emacs_abort () if it sees that waiting_for_input is set. */ waiting_for_input = 0; - run_hook (Qkill_emacs_hook); + if (noninteractive) + safe_run_hooks (Qkill_emacs_hook); + else + run_hook (Qkill_emacs_hook); #ifdef HAVE_X_WINDOWS /* Transfer any clipboards we own to the clipboard manager. */