From: Glenn Morris <rgm@gnu.org>
To: 14548-done@debbugs.gnu.org
Subject: bug#14548: 24.3.1; [PATCH] image-dired-dired-toggle-marked-thumbs conflicts with other modes using overlays
Date: Thu, 13 Jun 2013 01:11:10 -0400 [thread overview]
Message-ID: <oir4g64mtt.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <1qr4g8lb29.fsf@fencepost.gnu.org> (Glenn Morris's message of "Tue, 11 Jun 2013 15:08:46 -0400")
Version: 24.4
Applied in this form.
> *** lisp/image-dired.el 2013-02-17 00:45:53 +0000
> --- lisp/image-dired.el 2013-06-11 19:00:18 +0000
> ***************
> *** 657,665 ****
> (string-match-p (image-file-name-regexp) image-file))
> (setq thumb-file (image-dired-get-thumbnail-image image-file))
> ;; If image is not already added, then add it.
> ! (let ((cur-ov (overlays-in (point) (1+ (point)))))
> ! (if cur-ov
> ! (delete-overlay (car cur-ov))
> (put-image thumb-file image-pos)
> (setq overlay
> (cl-loop for o in (overlays-in (point) (1+ (point)))
> --- 657,668 ----
> (string-match-p (image-file-name-regexp) image-file))
> (setq thumb-file (image-dired-get-thumbnail-image image-file))
> ;; If image is not already added, then add it.
> ! (let* ((cur-ovs (overlays-in (point) (1+ (point))))
> ! (thumb-ov (car (cl-remove-if-not
> ! (lambda (ov) (overlay-get ov 'thumb-file))
> ! cur-ovs))))
> ! (if thumb-ov
> ! (delete-overlay thumb-ov)
> (put-image thumb-file image-pos)
> (setq overlay
> (cl-loop for o in (overlays-in (point) (1+ (point)))
next prev parent reply other threads:[~2013-06-13 5:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 13:28 bug#14548: 24.3.1; [PATCH] image-dired-dired-toggle-marked-thumbs conflicts with other modes using overlays E Sabof
2013-06-11 19:08 ` Glenn Morris
2013-06-11 21:56 ` Stefan Monnier
2013-06-11 22:12 ` Glenn Morris
2013-06-11 23:00 ` E Sabof
2013-06-12 12:01 ` E Sabof
2013-06-12 19:25 ` Stefan Monnier
2013-06-13 5:11 ` Glenn Morris [this message]
2013-06-13 14:18 ` Stefan Monnier
2013-06-13 14:39 ` E Sabof
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=oir4g64mtt.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=14548-done@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.