bug#26643: 26.0.50; not able to resize frame on OS X

bug#26643: 26.0.50; not able to resize frame on OS X

[Charles A. Roelli]

With a recent build of Emacs, if you try to resize a frame in OS X 10.6 
by dragging the bottom-right corner of the frame, the frame does not 
change size, and stderr says:

bash-3.2$ nextstep/Emacs.app/Contents/MacOS/Emacs -Q
2017-04-24 21:02:46.195 Emacs[45285:903] -[EmacsWindow titleVisibility]: 
unrecognized selector sent to instance 0x101aa1990

bug#26643: 26.0.50; not able to resize frame on OS X

[Charles A. Roelli]

On 24/04/2017 21:11, Charles A. Roelli wrote:
> With a recent build of Emacs, if you try to resize a frame in OS X 10.6
> by dragging the bottom-right corner of the frame, the frame does not
> change size, and stderr says:
>
> bash-3.2$ nextstep/Emacs.app/Contents/MacOS/Emacs -Q
> 2017-04-24 21:02:46.195 Emacs[45285:903] -[EmacsWindow titleVisibility]:
> unrecognized selector sent to instance 0x101aa1990

This seems to fix it:

--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -6646,8 +6646,7 @@ - (NSSize)windowWillResize: (NSWindow *)sender 
toSize: (NSSize)frameSize
              old_title = 0;
            }
        }
-    else if (fs_state == FULLSCREEN_NONE && ! maximizing_resize
-             && [[self window] titleVisibility])
+    else if (fs_state == FULLSCREEN_NONE && ! maximizing_resize)
        {
          char *size_title;
          NSWindow *window = [self window];

With the titleVisibility call, the compiler gives this warning:

nsterm.m: In function ‘-[EmacsView windowWillResize:toSize:]’:
nsterm.m:6650: warning: ‘NSWindow’ may not respond to ‘-titleVisibility’
nsterm.m:6650: warning: (Messages without a matching method signature
nsterm.m:6650: warning: will be assumed to return ‘id’ and accept
nsterm.m:6650: warning: ‘...’ as arguments.)

bug#26643: 26.0.50; not able to resize frame on OS X

[Alan Third]

On Mon, Apr 24, 2017 at 10:07:07PM +0200, Charles A. Roelli wrote:
> On 24/04/2017 21:11, Charles A. Roelli wrote:
> > With a recent build of Emacs, if you try to resize a frame in OS X 10.6
> > by dragging the bottom-right corner of the frame, the frame does not
> > change size, and stderr says:
> > 
> > bash-3.2$ nextstep/Emacs.app/Contents/MacOS/Emacs -Q
> > 2017-04-24 21:02:46.195 Emacs[45285:903] -[EmacsWindow titleVisibility]:
> > unrecognized selector sent to instance 0x101aa1990
> 
> This seems to fix it:
<snip>
> -    else if (fs_state == FULLSCREEN_NONE && ! maximizing_resize
> -             && [[self window] titleVisibility])
> +    else if (fs_state == FULLSCREEN_NONE && ! maximizing_resize)

Unfortunately removing the title test introduces a crash bug under
certain circumstances.

Can you try replacing it with this:

    else if (fs_state == FULLSCREEN_NONE && ! maximizing_resize
             && [[self window] title] != NULL)

and let me know if it fixes the resizing problem?

Thanks!
-- 
Alan Third

bug#26643: 26.0.50; not able to resize frame on OS X

[Charles A. Roelli]

> Unfortunately removing the title test introduces a crash bug under
> certain circumstances.
>
> Can you try replacing it with this:
>
>     else if (fs_state == FULLSCREEN_NONE && ! maximizing_resize
>              && [[self window] title] != NULL)
>
> and let me know if it fixes the resizing problem?
>
> Thanks!

This does fix the issue.  Thanks for the help!