From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#12610: unable to use macro in defadvice Date: Thu, 11 Oct 2012 22:05:43 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1350007580 25209 80.91.229.3 (12 Oct 2012 02:06:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 12 Oct 2012 02:06:20 +0000 (UTC) Cc: 12610@debbugs.gnu.org To: Le Wang Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 12 04:06:24 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TMUds-00085d-M1 for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 Oct 2012 04:06:24 +0200 Original-Received: from localhost ([::1]:56114 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TMUdl-0001KB-QL for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Oct 2012 22:06:17 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:38469) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TMUdk-0001Jv-8A for bug-gnu-emacs@gnu.org; Thu, 11 Oct 2012 22:06:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TMUdj-0002oB-7P for bug-gnu-emacs@gnu.org; Thu, 11 Oct 2012 22:06:16 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58092) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TMUdj-0002o7-48 for bug-gnu-emacs@gnu.org; Thu, 11 Oct 2012 22:06:15 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TMUeU-0004tb-6z for bug-gnu-emacs@gnu.org; Thu, 11 Oct 2012 22:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Oct 2012 02:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12610 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12610-submit@debbugs.gnu.org id=B12610.135000759418784 (code B ref 12610); Fri, 12 Oct 2012 02:07:02 +0000 Original-Received: (at 12610) by debbugs.gnu.org; 12 Oct 2012 02:06:34 +0000 Original-Received: from localhost ([127.0.0.1]:40110 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TMUe2-0004sv-3A for submit@debbugs.gnu.org; Thu, 11 Oct 2012 22:06:34 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:59059 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TMUe0-0004so-74 for 12610@debbugs.gnu.org; Thu, 11 Oct 2012 22:06:32 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1TMUdD-0001p1-RO; Thu, 11 Oct 2012 22:05:44 -0400 X-Spook: BLU-114/B bank enforcers national information X-Ran: g[LJ=YqmUu[~zZ8Hm!f(GW-WGhAT2osI=|t)fU&U[Q(:5bBkUcnfLJI~?#V_FsNHJNwoQv X-Hue: black X-Attribution: GM In-Reply-To: (Le Wang's message of "Tue, 9 Oct 2012 21:02:58 +0800") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:65506 Archived-At: Interesting. Advice does not macroexpand the advice definition. I guess it should? *** lisp/emacs-lisp/advice.el 2012-09-14 13:44:31 +0000 --- lisp/emacs-lisp/advice.el 2012-10-12 02:02:39 +0000 *************** *** 3658,3664 **** (advice (ad-make-advice name (memq 'protect flags) (not (memq 'disable flags)) ! `(advice lambda ,arglist ,@body))) (preactivation (if (memq 'preactivate flags) (ad-preactivate-advice function advice class position)))) --- 3658,3664 ---- (advice (ad-make-advice name (memq 'protect flags) (not (memq 'disable flags)) ! `(advice lambda ,arglist ,@(macroexpand-all body)))) (preactivation (if (memq 'preactivate flags) (ad-preactivate-advice function advice class position))))