Re: [Emacs-diffs] emacs/src fileio.c

Re: [Emacs-diffs] emacs/src fileio.c

[Juanma Barranquero]

On Thu, Oct 1, 2009 at 17:07, Michael Albinus <Michael.Albinus@gmx.de> wrote:

> Modified files:
>        src            : fileio.c
>
> Log message:
>        * fileio.c (Fdelete_directory_internal): Renamed from
>        Fdelete_directory.  It is not a command anymore.  It has no file
>        name handler.

I've changed w32fns.c:Fsystem_move_file_to_trash to use
Fdelete_directory_internal instead of Fdelete_directory so Emacs can
bootstrap again on Windows.

But Fdelete_directory_internal is now skipping the file name handler,
so it is likely not safe?

    Juanma

Re: [Emacs-diffs] emacs/src fileio.c

[Michael Albinus]

Juanma Barranquero <lekktu@gmail.com> writes:

> I've changed w32fns.c:Fsystem_move_file_to_trash to use
> Fdelete_directory_internal instead of Fdelete_directory so Emacs can
> bootstrap again on Windows.
>
> But Fdelete_directory_internal is now skipping the file name handler,
> so it is likely not safe?

I believe, we should rather use

  intern ("delete-directory")

Qdelete_directory_internal could be removed from lisp.h then.

Best regards, Michael.

>     Juanma

Re: [Emacs-diffs] emacs/src fileio.c

[Juanma Barranquero]

On Fri, Oct 2, 2009 at 07:54, Michael Albinus <michael.albinus@gmx.de> wrote:

> I believe, we should rather use
>
>  intern ("delete-directory")
>
> Qdelete_directory_internal could be removed from lisp.h then.

OK, thanks for fixing it.

    Juanma