all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Tramp and rcompile
@ 2008-01-30 20:54 Stefan Monnier
  2008-01-31 10:31 ` Michael Albinus
  0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2008-01-30 20:54 UTC (permalink / raw)
  To: emacs-devel


The `rcompile' code calls a Tramp macro via `funcall'.
Obviously, this can't work.  This code was introduced by Michael Albinus
<michael.albinus@gmx.de> back in 2006, so I presume that the macro was
a function back then (or he had had too much fun the previous night).

I'm tempted to just throw out most of that code since M-x compile should
work at least as well for that purpose nowadays.  But if someone who
actually knows about `rcompile' and/or uses the remote compilation
feature of `compile' could DTRT, it'd be better.


        Stefan




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Tramp and rcompile
  2008-01-30 20:54 Tramp and rcompile Stefan Monnier
@ 2008-01-31 10:31 ` Michael Albinus
  2008-01-31 15:04   ` Stefan Monnier
  0 siblings, 1 reply; 3+ messages in thread
From: Michael Albinus @ 2008-01-31 10:31 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> The `rcompile' code calls a Tramp macro via `funcall'.
> Obviously, this can't work.  This code was introduced by Michael Albinus
> <michael.albinus@gmx.de> back in 2006, so I presume that the macro was
> a function back then (or he had had too much fun the previous night).

Likely the latter one, I don't remember. But it looks like I've tested
only the not byte-compiled version ...

> I'm tempted to just throw out most of that code since M-x compile should
> work at least as well for that purpose nowadays.

I second this. I have had always a bad feeling, using Tramp *internal*
functions somewhere else.

>         Stefan

Best regards, Michael.





^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Tramp and rcompile
  2008-01-31 10:31 ` Michael Albinus
@ 2008-01-31 15:04   ` Stefan Monnier
  0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2008-01-31 15:04 UTC (permalink / raw)
  To: Michael Albinus; +Cc: emacs-devel

>> The `rcompile' code calls a Tramp macro via `funcall'.
>> Obviously, this can't work.  This code was introduced by Michael Albinus
>> <michael.albinus@gmx.de> back in 2006, so I presume that the macro was
>> a function back then (or he had had too much fun the previous night).

> Likely the latter one, I don't remember.  But it looks like I've tested
> only the not byte-compiled version ...

Going through an explicit `funcall' should ensure that it will fail even
if you don't byte-compile the file.

>> I'm tempted to just throw out most of that code since M-x compile should
>> work at least as well for that purpose nowadays.

> I second this.  I have had always a bad feeling, using Tramp *internal*
> functions somewhere else.

OK, so I'll remove the obviously broken code (it will still use an
internal Tramp function, tho).
I also suggest we move rcompile.el to the `obsolete' directory.


        Stefan




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-01-31 15:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-30 20:54 Tramp and rcompile Stefan Monnier
2008-01-31 10:31 ` Michael Albinus
2008-01-31 15:04   ` Stefan Monnier

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.