From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#14254: 24.3; read-number fails to recognize faulty numbers (string-to-number to blame) Date: Wed, 24 Apr 2013 13:29:18 -0400 Message-ID: References: <87ehe0ayf9.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1366824604 3081 80.91.229.3 (24 Apr 2013 17:30:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 24 Apr 2013 17:30:04 +0000 (UTC) Cc: 14254@debbugs.gnu.org To: Vitalie Spinu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 24 19:30:05 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UV3W8-00085b-0n for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Apr 2013 19:30:04 +0200 Original-Received: from localhost ([::1]:36582 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UV3W7-0002v9-Kp for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Apr 2013 13:30:03 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:37346) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UV3W4-0002us-EP for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2013 13:30:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UV3W2-0006JO-Tf for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2013 13:30:00 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37210) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UV3W2-0006JG-Q2 for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2013 13:29:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UV3av-0000d3-IH for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2013 13:35:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Apr 2013 17:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14254 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14254-submit@debbugs.gnu.org id=B14254.13668248652282 (code B ref 14254); Wed, 24 Apr 2013 17:35:01 +0000 Original-Received: (at 14254) by debbugs.gnu.org; 24 Apr 2013 17:34:25 +0000 Original-Received: from localhost ([127.0.0.1]:41319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UV3aK-0000al-PC for submit@debbugs.gnu.org; Wed, 24 Apr 2013 13:34:25 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:53771) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UV3aI-0000ad-Mc for 14254@debbugs.gnu.org; Wed, 24 Apr 2013 13:34:23 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1UV3VO-0003FI-DB; Wed, 24 Apr 2013 13:29:18 -0400 X-Spook: satellite imagery SAFE USCODE propaganda SCUD missile X-Ran: 1P205$00RBR4g|g47fmsPa;sT'TcU (Vitalie Spinu's message of "Wed, 24 Apr 2013 14:46:50 +0200") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:73641 Archived-At: Vitalie Spinu wrote: > This doesn't happen because read-number relies on string-to-number to > throw an error, which presumably was happening some time ago. No, it used to use "read", prior to http://lists.gnu.org/archive/html/emacs-diffs/2012-07/msg00477.html Replace `read' with `string-to-number' for consistency with `number-to-string'. I don't know why that mattered, it seems to bear no relation to the rest of the change. Going back to "read" again will fix this. Done in emacs-24.