* Re: [Emacs-diffs] trunk r116878: Sync with upstream vhdl mode v3.35.1 [not found] <E1WSez3-0007bu-Ro@vcs.savannah.gnu.org> @ 2014-03-26 12:49 ` Stefan Monnier 2014-03-26 15:56 ` Glenn Morris 0 siblings, 1 reply; 10+ messages in thread From: Stefan Monnier @ 2014-03-26 12:49 UTC (permalink / raw) To: Reto Zimmermann; +Cc: emacs-devel > ;; function for expanding abbrevs and dabbrevs > -(defalias 'vhdl-expand-abbrev (make-hippie-expand-function > - '(try-expand-dabbrev > - try-expand-dabbrev-all-buffers > - vhdl-try-expand-abbrev))) > +(defun vhdl-expand-abbrev (arg)) > +(fset 'vhdl-expand-abbrev (make-hippie-expand-function > + '(try-expand-dabbrev > + try-expand-dabbrev-all-buffers > + vhdl-try-expand-abbrev))) Why??!?! Stefan ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Emacs-diffs] trunk r116878: Sync with upstream vhdl mode v3.35.1 2014-03-26 12:49 ` [Emacs-diffs] trunk r116878: Sync with upstream vhdl mode v3.35.1 Stefan Monnier @ 2014-03-26 15:56 ` Glenn Morris 2014-03-28 12:50 ` Reto Zimmermann 0 siblings, 1 reply; 10+ messages in thread From: Glenn Morris @ 2014-03-26 15:56 UTC (permalink / raw) To: Stefan Monnier; +Cc: Reto Zimmermann, emacs-devel Stefan Monnier wrote: >> ;; function for expanding abbrevs and dabbrevs >> -(defalias 'vhdl-expand-abbrev (make-hippie-expand-function >> - '(try-expand-dabbrev >> - try-expand-dabbrev-all-buffers >> - vhdl-try-expand-abbrev))) >> +(defun vhdl-expand-abbrev (arg)) >> +(fset 'vhdl-expand-abbrev (make-hippie-expand-function >> + '(try-expand-dabbrev >> + try-expand-dabbrev-all-buffers >> + vhdl-try-expand-abbrev))) > > Why??!?! Yes, that made no sense to me either. I meant to think about it before committing, then forgot. My random guess would be compat with old Emacs versions. This is how the code used to be prior to Emacs trunk r108403. There's no ChangeLog information associated with that commit. Knowing why it was changed that time would have helped. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Emacs-diffs] trunk r116878: Sync with upstream vhdl mode v3.35.1 2014-03-26 15:56 ` Glenn Morris @ 2014-03-28 12:50 ` Reto Zimmermann 2014-03-28 14:54 ` Stefan Monnier 0 siblings, 1 reply; 10+ messages in thread From: Reto Zimmermann @ 2014-03-28 12:50 UTC (permalink / raw) To: Glenn Morris; +Cc: Stefan Monnier, emacs-devel Quoting Glenn Morris <rgm@gnu.org>: > Stefan Monnier wrote: > >>> ;; function for expanding abbrevs and dabbrevs >>> -(defalias 'vhdl-expand-abbrev (make-hippie-expand-function >>> - '(try-expand-dabbrev >>> - try-expand-dabbrev-all-buffers >>> - vhdl-try-expand-abbrev))) >>> +(defun vhdl-expand-abbrev (arg)) >>> +(fset 'vhdl-expand-abbrev (make-hippie-expand-function >>> + '(try-expand-dabbrev >>> + try-expand-dabbrev-all-buffers >>> + vhdl-try-expand-abbrev))) >> >> Why??!?! > > Yes, that made no sense to me either. > I meant to think about it before committing, then forgot. > My random guess would be compat with old Emacs versions. > > This is how the code used to be prior to Emacs trunk r108403. > There's no ChangeLog information associated with that commit. > Knowing why it was changed that time would have helped. In 2007 I changed my own copy of vhdl-mode to use defalias. In 2012 I synced some differences from the GNU distribution to my own copy, so it went back to defun/fset (because that's what it was in the repository). I didn't think much about it, so I don't think there was any other reason than just to be in sync with the GNU version. There's other things that are probably still different in my own copy compared to the GNU version, that I did not sync because of compatibility reasons. I meanwhile dropped compatibility with XEmacs, but I still want to prevent any changes that are not compatible with older Emacs versions in the copy that I distribute on my site. Reto ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Emacs-diffs] trunk r116878: Sync with upstream vhdl mode v3.35.1 2014-03-28 12:50 ` Reto Zimmermann @ 2014-03-28 14:54 ` Stefan Monnier 2014-03-28 19:40 ` Reto Zimmermann 2014-03-28 20:39 ` Reto Zimmermann 0 siblings, 2 replies; 10+ messages in thread From: Stefan Monnier @ 2014-03-28 14:54 UTC (permalink / raw) To: Reto Zimmermann; +Cc: emacs-devel > In 2007 I changed my own copy of vhdl-mode to use defalias. In 2012 > I synced some differences from the GNU distribution to my own copy, so it > went back to defun/fset (because that's what it was in the repository). > I didn't think much about it, so I don't think there was any other reason > than just to be in sync with the GNU version. So going back to defun+fset was an accident. Thanks. > There's other things that are probably still different in my own copy > compared to the GNU version, that I did not sync because of compatibility > reasons. I meanwhile dropped compatibility with XEmacs, but I still want > to prevent any changes that are not compatible with older Emacs versions in > the copy that I distribute on my site. We generally prefer it if the code in Emacs is identical to the one you distribute, even if it means keeping compatibility code around. We do like to make use of newer features, but in 99% of the case that can be done without breaking compatibility. I tend to break that compatibility when I install my own changes, but that's usually by accident or at worst out of laziness (e.g. sometimes I know it breaks compatibility but I suspect that this compatibility is not important any more, so I deliberately break it and wait to see if someone yells). IOW, feel free to send us patches that just fix backward compatibility issues, and if you don't know how to combine the "new" and the "old" code, we can probably help. Stefan ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Emacs-diffs] trunk r116878: Sync with upstream vhdl mode v3.35.1 2014-03-28 14:54 ` Stefan Monnier @ 2014-03-28 19:40 ` Reto Zimmermann 2014-03-28 19:47 ` Glenn Morris 2014-03-28 22:53 ` Stefan Monnier 2014-03-28 20:39 ` Reto Zimmermann 1 sibling, 2 replies; 10+ messages in thread From: Reto Zimmermann @ 2014-03-28 19:40 UTC (permalink / raw) To: Stefan Monnier; +Cc: emacs-devel > We generally prefer it if the code in Emacs is identical to the one you > distribute, even if it means keeping compatibility code around. Okay. With the minor changes I'm making in vhdl-mode nowadays I don't care that much about compatibility anymore either. > IOW, feel free to send us patches that just fix backward compatibility > issues, and if you don't know how to combine the "new" and the "old" > code, we can probably help. Alright. I will check out the code you come up with and let you know the things I don't like. In the past there were changes done in the Emacs version that I didn't like or didn't understand and therefore I didn't bother to keep my copy in sync. I will try harder now! BTW, I was a heavy user of the (now deprecated) assoc package and didn't find a suitable replacement. So I just copied the relevant functions into vhdl-mode. If you have a better solution, let me know. Reto ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Emacs-diffs] trunk r116878: Sync with upstream vhdl mode v3.35.1 2014-03-28 19:40 ` Reto Zimmermann @ 2014-03-28 19:47 ` Glenn Morris 2014-03-28 19:49 ` Reto Zimmermann 2014-03-28 22:53 ` Stefan Monnier 1 sibling, 1 reply; 10+ messages in thread From: Glenn Morris @ 2014-03-28 19:47 UTC (permalink / raw) To: Reto Zimmermann; +Cc: Stefan Monnier, emacs-devel Reto Zimmermann wrote: > BTW, I was a heavy user of the (now deprecated) assoc package and > didn't find a suitable replacement. So I just copied the relevant > functions into vhdl-mode. If you have a better solution, let me know. At the very least, you should rename your versions to vhdl-aget, etc. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Emacs-diffs] trunk r116878: Sync with upstream vhdl mode v3.35.1 2014-03-28 19:47 ` Glenn Morris @ 2014-03-28 19:49 ` Reto Zimmermann 0 siblings, 0 replies; 10+ messages in thread From: Reto Zimmermann @ 2014-03-28 19:49 UTC (permalink / raw) To: Glenn Morris; +Cc: Stefan Monnier, emacs-devel >> BTW, I was a heavy user of the (now deprecated) assoc package and >> didn't find a suitable replacement. So I just copied the relevant >> functions into vhdl-mode. If you have a better solution, let me know. > > At the very least, you should rename your versions to vhdl-aget, etc. You're right, will do that. Reto ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Emacs-diffs] trunk r116878: Sync with upstream vhdl mode v3.35.1 2014-03-28 19:40 ` Reto Zimmermann 2014-03-28 19:47 ` Glenn Morris @ 2014-03-28 22:53 ` Stefan Monnier 2014-03-29 0:39 ` Reto Zimmermann 1 sibling, 1 reply; 10+ messages in thread From: Stefan Monnier @ 2014-03-28 22:53 UTC (permalink / raw) To: Reto Zimmermann; +Cc: emacs-devel > BTW, I was a heavy user of the (now deprecated) assoc package and didn't > find a suitable replacement. (aget alist key t) is just a convoluted way to do (cdr (assoc key alist)) (aget alist key) is probably equivalent to (let ((x (assoc key alist))) (if x (or (cdr x) key))) tho it's a sufficiently strange behavior that I doubt you'll ever need/want it. `aput' is generally advantageously replaced by `push'. Stefan ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Emacs-diffs] trunk r116878: Sync with upstream vhdl mode v3.35.1 2014-03-28 22:53 ` Stefan Monnier @ 2014-03-29 0:39 ` Reto Zimmermann 0 siblings, 0 replies; 10+ messages in thread From: Reto Zimmermann @ 2014-03-29 0:39 UTC (permalink / raw) To: Stefan Monnier; +Cc: emacs-devel > `aput' is generally advantageously replaced by `push'. I need more of the special behavior of 'aput', like replacing the value if key already exists in the alist, thus making sure there are no duplicates of key. But I'm sure it can be implemented more efficiently, especially since I don't need the key to be sorted to the head of the list. Reto ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Emacs-diffs] trunk r116878: Sync with upstream vhdl mode v3.35.1 2014-03-28 14:54 ` Stefan Monnier 2014-03-28 19:40 ` Reto Zimmermann @ 2014-03-28 20:39 ` Reto Zimmermann 1 sibling, 0 replies; 10+ messages in thread From: Reto Zimmermann @ 2014-03-28 20:39 UTC (permalink / raw) To: Stefan Monnier; +Cc: emacs-devel Here's the latest version 3.35.2 with some small recent changes and all copied functions from assoc.el renamed to vhdl-*. ChangeLog: 2014-03-28 Reto Zimmermann <reto@gnu.org> * vhdl-mode.el (vhdl-compile-init): Not initialize regexps for Emacs 22+. (vhdl-error-regexp-emacs-alist): Remove regexps from all compilers except `vhdl-compiler'. (vhdl-template-replace-header-keywords): Fix bug for "<title string>". (vhdl-aput, vhdl-adelete, vhdl-aget): Rename functions from assoc.el. Reto ----- Attachments (links will expire on 09/30/2014): 1. vhdl-mode.el.zip (141 KB) [application/zip] Download link: http://webmail.retoweb.net/imp/attachment.php?id=5335ddcf-2d6c-41b5-a438-0bdc50bef09b&u=reto%40retoweb.net ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-03-29 0:39 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <E1WSez3-0007bu-Ro@vcs.savannah.gnu.org> 2014-03-26 12:49 ` [Emacs-diffs] trunk r116878: Sync with upstream vhdl mode v3.35.1 Stefan Monnier 2014-03-26 15:56 ` Glenn Morris 2014-03-28 12:50 ` Reto Zimmermann 2014-03-28 14:54 ` Stefan Monnier 2014-03-28 19:40 ` Reto Zimmermann 2014-03-28 19:47 ` Glenn Morris 2014-03-28 19:49 ` Reto Zimmermann 2014-03-28 22:53 ` Stefan Monnier 2014-03-29 0:39 ` Reto Zimmermann 2014-03-28 20:39 ` Reto Zimmermann
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.