From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel Subject: Re: :alnum: broken? Date: Wed, 26 Feb 2020 17:01:41 +0100 Message-ID: References: <86wo8flqct.fsf@stephe-leake.org> <86sgj3ljf0.fsf@stephe-leake.org> <5fecc0e1-1ee2-5a89-9297-b0b9aa4a8e9c@cs.ucla.edu> <03A37C4B-9FE8-4A25-9851-79BC8265455E@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="55264"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: Paul Eggert , Stephen Leake , emacs-devel To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Feb 26 17:03:42 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j6z9y-000EFl-Rk for ged-emacs-devel@m.gmane-mx.org; Wed, 26 Feb 2020 17:03:42 +0100 Original-Received: from localhost ([::1]:46414 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6z9x-0000pB-To for ged-emacs-devel@m.gmane-mx.org; Wed, 26 Feb 2020 11:03:41 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42275) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6z86-0007Ir-GG for emacs-devel@gnu.org; Wed, 26 Feb 2020 11:01:47 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6z85-0008EE-54 for emacs-devel@gnu.org; Wed, 26 Feb 2020 11:01:46 -0500 Original-Received: from mx2.suse.de ([195.135.220.15]:51686) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6z84-0008C2-TF for emacs-devel@gnu.org; Wed, 26 Feb 2020 11:01:45 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Original-Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 8B5B9ACA1; Wed, 26 Feb 2020 16:01:42 +0000 (UTC) X-Yow: My pants just went to high school in the Carlsbad Caverns!!! In-Reply-To: <03A37C4B-9FE8-4A25-9851-79BC8265455E@acm.org> ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Wed, 26 Feb 2020 15:10:46 +0100") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-Received-From: 195.135.220.15 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:245076 Archived-At: On Feb 26 2020, Mattias Engdeg=C3=A5rd wrote: > @@ -2000,6 +2002,23 @@ regex_compile (re_char *pattern, ptrdiff_t size, > =20 > laststart =3D b; > =20 > + /* Check for the mistake of forgetting the extra square br= ackets, > + as in "[:alpha:]". */ > + if (*p =3D=3D ':') > + { > + re_char *q =3D p + 1; > + while (q !=3D pend && *q !=3D ']') > + { > + if (*q =3D=3D ':') > + { > + if (q + 1 !=3D pend && q[1] =3D=3D ']' && q > = p + 1) > + FREE_STACK_RETURN (REG_ECLASSBR); > + break; > + } > + q++; > + } > + } > + That would break "[:[:alpha:]]". Andreas. --=20 Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint =3D 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D= 7 "And now for something completely different."