From: Andreas Schwab <schwab@suse.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Ulrich Mueller <ulm@gentoo.org>, Paul Eggert <eggert@cs.ucla.edu>,
30855@debbugs.gnu.org, gentoo-bug@opensource.sf-tec.de
Subject: bug#30855: 25.3; temacs fails with bus error during garbage collection
Date: Tue, 20 Mar 2018 16:26:19 +0100 [thread overview]
Message-ID: <mvmsh8uhip0.fsf@suse.de> (raw)
In-Reply-To: <83y3imls72.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 20 Mar 2018 16:47:29 +0200")
On Mär 20 2018, Eli Zaretskii <eliz@gnu.org> wrote:
> So you are saying that we should be doing the below instead?
>
> diff --git a/src/alloc.c b/src/alloc.c
> index 9d0e2d3..18546ca 100644
> --- a/src/alloc.c
> +++ b/src/alloc.c
> @@ -4983,7 +4983,8 @@ mark_memory (void *start, void *end)
> for (pp = start; (void *) pp < end; pp += GC_POINTER_ALIGNMENT)
> {
> mark_maybe_pointer (*(void **) pp);
> - mark_maybe_object (*(Lisp_Object *) pp);
> + if ((intptr_t) pp % GCALIGNMENT == 0)
That should be alignof(Lisp_Object). A Lisp_Object only needs
Lisp_Object alignment. GCALIGNMENT is about the _value_ of a
Lisp_Object (ie. the address of the Lisp object that this Lisp_Object
points to).
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2018-03-20 15:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 15:23 bug#30855: 25.3; temacs fails with bus error during garbage collection Ulrich Mueller
2018-03-19 19:19 ` Eli Zaretskii
2018-03-20 14:00 ` Ulrich Mueller
2018-03-20 14:47 ` Eli Zaretskii
2018-03-20 15:26 ` Andreas Schwab [this message]
2018-03-20 16:40 ` Eli Zaretskii
2018-03-20 16:58 ` Paul Eggert
2018-03-20 17:15 ` Eli Zaretskii
2018-03-20 21:19 ` Ulrich Mueller
2018-03-20 21:42 ` Paul Eggert
2018-03-21 6:20 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmsh8uhip0.fsf@suse.de \
--to=schwab@suse.de \
--cc=30855@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=gentoo-bug@opensource.sf-tec.de \
--cc=ulm@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.