From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel Subject: Re: Why does make run git? Date: Wed, 16 Aug 2017 14:49:00 +0200 Message-ID: References: <83bmo00yw7.fsf@gnu.org> <6d947774-836a-7286-4214-ddc5f516577f@cs.ucla.edu> <87bmngnccv.fsf@lifelogs.com> <87zib0lqdo.fsf@lifelogs.com> <7a270049-7aec-6b99-2a88-06379548b339@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1502887796 18859 195.159.176.226 (16 Aug 2017 12:49:56 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 16 Aug 2017 12:49:56 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) Cc: emacs-devel@gnu.org To: Andy Moreton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 16 14:49:53 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhxlZ-00048K-VF for ged-emacs-devel@m.gmane.org; Wed, 16 Aug 2017 14:49:46 +0200 Original-Received: from localhost ([::1]:44273 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhxld-0002gX-CA for ged-emacs-devel@m.gmane.org; Wed, 16 Aug 2017 08:49:49 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41396) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhxkx-0002fp-2l for emacs-devel@gnu.org; Wed, 16 Aug 2017 08:49:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhxku-0000vg-0E for emacs-devel@gnu.org; Wed, 16 Aug 2017 08:49:07 -0400 Original-Received: from mx2.suse.de ([195.135.220.15]:58223 helo=mx1.suse.de) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dhxkt-0000sV-Qd for emacs-devel@gnu.org; Wed, 16 Aug 2017 08:49:03 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Original-Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 4ACABAD88; Wed, 16 Aug 2017 12:49:01 +0000 (UTC) X-Yow: Maybe we could paint GOLDIE HAWN a rich PRUSSIAN BLUE-- In-Reply-To: (Andy Moreton's message of "Wed, 16 Aug 2017 13:30:12 +0100") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Received-From: 195.135.220.15 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217587 Archived-At: On Aug 16 2017, Andy Moreton wrote: > On Tue 15 Aug 2017, Paul Eggert wrote: > >> Ted Zlatanov wrote: >> >>> I think CONTRIBUTE should mention, right after saying to run autogen.sh, >>> that the above requires Git to be installed. >> >> autogen.sh is not supposed to require Git, so let's fix autogen.sh instead. >> >> >>> 'build-aux/git-hooks/commit-msg' -> '.git/hooks/commit-msg' >>> cp: cannot create regular file '.git/hooks/commit-msg': No such file or directory >>> ERROR: Job failed: exit code 1 >>> #+end_src >>> >>> So it looks like it assumes that `.git/hooks' exists. I don't know why >>> that's not true in the GitLab checkout. >> >> I don't know why either. I wonder what other compatibility mines remain >> unexploded in the GitLab field? Anyway, I installed the attached, which should >> work around this particular problem without having to complicate the >> configuration instructions. > > Is it possible that gitlab is using git worktrees, in which case .git in > the worktree is a regular file and not a directory ? .git must already exist as a directory, otherwise '.git/config' -> '.git/config.~1~' wouldn't have worked. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."