From: Andreas Schwab <schwab@suse.de>
To: Bernardo <bernardo.bacic@pobox.com>
Cc: 37884@debbugs.gnu.org, Robert Pluim <rpluim@gmail.com>
Subject: bug#37884: 27.0.50; Cannot write to a file in VirtualBox shared directory
Date: Tue, 29 Oct 2019 10:04:01 +0100 [thread overview]
Message-ID: <mvmmudjj532.fsf@suse.de> (raw)
In-Reply-To: <87zhhkc4vs.fsf@pobox.com> (Bernardo's message of "Tue, 29 Oct 2019 19:50:15 +1100")
On Okt 29 2019, Bernardo wrote:
> diff --git a/src/filelock.c b/src/filelock.c
> index ff25d6475d..046a1b014f 100644
> --- a/src/filelock.c
> +++ b/src/filelock.c
> @@ -732,6 +732,16 @@ unlock_file (Lisp_Object fn)
> int err = current_lock_owner (0, lfname);
> if (err == -2 && unlink (lfname) != 0 && errno != ENOENT)
> err = errno;
> + /* On certain filesystems the file must be writable for unlink to
> + succeed (Bug#37784). */
> + if (errno == EPERM)
You need to move this check under the condition above, otherwise you may
get a false positive if unlink didn't fail or wasn't called at all.
> + {
> + chmod (lfname, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
> + err = 0;
> + errno = 0;
No need to clear errno here.
> + if (unlink (lfname) != 0 && errno != ENOENT)
> + err = errno;
> + }
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2019-10-29 9:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 10:28 bug#37884: 27.0.50; Cannot write to a file in VirtualBox shared directory Bernardo
2019-10-24 16:10 ` Robert Pluim
[not found] ` <87blu2emi3.fsf@pobox.com>
2019-10-27 15:34 ` Robert Pluim
2019-10-27 15:52 ` Eli Zaretskii
2019-10-27 16:01 ` Robert Pluim
2019-10-27 16:34 ` Eli Zaretskii
2019-10-28 9:23 ` Bernardo
2019-10-28 12:32 ` Robert Pluim
2019-10-29 8:50 ` Bernardo
2019-10-29 9:04 ` Andreas Schwab [this message]
2019-10-29 13:41 ` Robert Pluim
2019-10-30 8:44 ` Bernardo
2019-10-30 13:31 ` Robert Pluim
2019-10-30 16:25 ` Eli Zaretskii
2019-10-31 1:41 ` Paul Eggert
2019-10-31 7:38 ` Robert Pluim
2019-10-31 14:37 ` Eli Zaretskii
2019-10-31 21:24 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmmudjj532.fsf@suse.de \
--to=schwab@suse.de \
--cc=37884@debbugs.gnu.org \
--cc=bernardo.bacic@pobox.com \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.