From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.bugs Subject: bug#19192: 25.0.50; TRAMP uses `dired-listing-switches' for ftp-connection Date: Wed, 10 Dec 2014 15:15:53 +0100 Message-ID: References: <87tx1mrwwq.fsf@gmx.us> <87zjbe9j9c.fsf@gmx.de> <87h9xlil0f.fsf@gmx.us> <877fye2spw.fsf@gmx.de> <87mw7afe90.fsf@gmx.us> <87a9393pw2.fsf@gmx.de> <874mtgamf3.fsf@gmx.us> <878uihj5ai.fsf@gmx.de> <87k31zfxw6.fsf@gmx.us> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1418220988 1378 80.91.229.3 (10 Dec 2014 14:16:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 10 Dec 2014 14:16:28 +0000 (UTC) Cc: 19192@debbugs.gnu.org, michael.albinus@gmx.de To: Rasmus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 10 15:16:21 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Xyi3v-0000oi-SX for geb-bug-gnu-emacs@m.gmane.org; Wed, 10 Dec 2014 15:16:20 +0100 Original-Received: from localhost ([::1]:45961 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xyi3v-0007Iy-BM for geb-bug-gnu-emacs@m.gmane.org; Wed, 10 Dec 2014 09:16:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41160) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xyi3k-00079G-QY for bug-gnu-emacs@gnu.org; Wed, 10 Dec 2014 09:16:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xyi3e-0003nL-T3 for bug-gnu-emacs@gnu.org; Wed, 10 Dec 2014 09:16:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34947) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xyi3e-0003nG-QT for bug-gnu-emacs@gnu.org; Wed, 10 Dec 2014 09:16:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Xyi3e-0001cr-GG for bug-gnu-emacs@gnu.org; Wed, 10 Dec 2014 09:16:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Dec 2014 14:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19192 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19192-submit@debbugs.gnu.org id=B19192.14182209586235 (code B ref 19192); Wed, 10 Dec 2014 14:16:02 +0000 Original-Received: (at 19192) by debbugs.gnu.org; 10 Dec 2014 14:15:58 +0000 Original-Received: from localhost ([127.0.0.1]:60393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xyi3Z-0001cV-OT for submit@debbugs.gnu.org; Wed, 10 Dec 2014 09:15:58 -0500 Original-Received: from cantor2.suse.de ([195.135.220.15]:43061 helo=mx2.suse.de) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xyi3W-0001cL-Gm for 19192@debbugs.gnu.org; Wed, 10 Dec 2014 09:15:55 -0500 Original-Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id A4B2DAC40; Wed, 10 Dec 2014 14:15:53 +0000 (UTC) X-Yow: I can't think about that. It doesn't go with HEDGES in the shape of LITTLE LULU -- or ROBOTS making BRICKS... In-Reply-To: <87k31zfxw6.fsf@gmx.us> (rasmus@gmx.us's message of "Wed, 10 Dec 2014 14:16:25 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:97132 Archived-At: Rasmus writes: > diff --git a/lisp/net/ange-ftp.el b/lisp/net/ange-ftp.el > index d7632ed..5e9bc27 100644 > --- a/lisp/net/ange-ftp.el > +++ b/lisp/net/ange-ftp.el > @@ -2831,16 +2831,20 @@ match subdirectories as well.") > files ange-ftp-files-hashtable))) > > (defun ange-ftp-switches-ok (switches) > - "Return SWITCHES (a string) if suitable for our use." > + "Return SWITCHES (a string) if suitable for use with ls over ftp." > (and (stringp switches) > ;; We allow the A switch, which lists all files except "." and > ;; "..". This is OK because we manually insert these entries > ;; in the hash table. > (string-match > "--\\(almost-\\)?all\\>\\|\\(\\`\\| \\)-[[:alpha:]]*[aA]" switches) > + ;; Allow flags starting with a single dash > (string-match "\\(\\`\\| \\)-[[:alpha:]]*l" switches) > + ;; Disallow recursive flag > (not (string-match > - "--recursive\\>\\|\\(\\`\\| \\)-[[:alpha:]]*R" switches)) > + "\\(\\`\\| \\)-[[:alpha:]]*R" switches)) > + ;; Disallow long flags. > + (not (string-match "--\\w\\{2,\\}")) This contradicts the first string-match. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."