From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.bugs Subject: bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes Date: Wed, 26 Jun 2019 10:50:24 +0200 Message-ID: References: <2a6ff247-2b75-4f85-9a4c-889576ed7b34@default> <87o92lmgez.fsf@web.de> <87ftnxmfoo.fsf@web.de> <727b63b3-3571-4bcb-821a-6f9f9f4346a4@default> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="31614"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) Cc: Michael Heerdegen , Lars Ingebrigtsen , 22457@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 26 10:51:23 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hg3eA-0007yh-56 for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Jun 2019 10:51:18 +0200 Original-Received: from localhost ([::1]:37738 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hg3e8-0005TF-1z for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Jun 2019 04:51:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52180) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hg3dz-0005Sq-2F for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 04:51:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hg3dx-0000TJ-KC for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 04:51:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48908) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hg3du-0000Qg-EO for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 04:51:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hg3du-0008K1-BE for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 04:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Jun 2019 08:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22457 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 22457-submit@debbugs.gnu.org id=B22457.156153903531957 (code B ref 22457); Wed, 26 Jun 2019 08:51:02 +0000 Original-Received: (at 22457) by debbugs.gnu.org; 26 Jun 2019 08:50:35 +0000 Original-Received: from localhost ([127.0.0.1]:34219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hg3dS-0008JM-2c for submit@debbugs.gnu.org; Wed, 26 Jun 2019 04:50:35 -0400 Original-Received: from mx2.suse.de ([195.135.220.15]:42124 helo=mx1.suse.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hg3dP-0008J8-Vf for 22457@debbugs.gnu.org; Wed, 26 Jun 2019 04:50:32 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Original-Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id CA87AACA7; Wed, 26 Jun 2019 08:50:25 +0000 (UTC) X-Yow: I just heard the SEVENTIES were over!! And I was just getting in touch with my LEISURE SUIT!! In-Reply-To: <727b63b3-3571-4bcb-821a-6f9f9f4346a4@default> (Drew Adams's message of "Tue, 25 Jun 2019 16:26:58 -0700 (PDT)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161466 Archived-At: On Jun 25 2019, Drew Adams wrote: >> Oh, btw, this patch line >> >> (looking-at-p (char-to-string dired-marker-char)) >> >> is not good if dired-marker-char is a regexp special like . or ?, I >> guess (regexp-quote missing)? > > It's a good point; it would be clearer to wrap the > arg to `looking-at-p' with `regexp-quote'. I think it's better to say (eq (char-after) dired-marker-char). Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."