all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: Drew Adams <drew.adams@oracle.com>
Cc: Michael Heerdegen <michael_heerdegen@web.de>,
	Lars Ingebrigtsen <larsi@gnus.org>,
	22457@debbugs.gnu.org
Subject: bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes
Date: Wed, 26 Jun 2019 10:50:24 +0200	[thread overview]
Message-ID: <mvmk1d8vigf.fsf@suse.de> (raw)
In-Reply-To: <727b63b3-3571-4bcb-821a-6f9f9f4346a4@default> (Drew Adams's message of "Tue, 25 Jun 2019 16:26:58 -0700 (PDT)")

On Jun 25 2019, Drew Adams <drew.adams@oracle.com> wrote:

>> Oh, btw, this patch line
>> 
>>   (looking-at-p (char-to-string dired-marker-char))
>> 
>> is not good if dired-marker-char is a regexp special like . or ?, I
>> guess (regexp-quote missing)?
>
> It's a good point; it would be clearer to wrap the
> arg to `looking-at-p' with `regexp-quote'.

I think it's better to say (eq (char-after) dired-marker-char).

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."





  parent reply	other threads:[~2019-06-26  8:50 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-24 18:05 bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes Drew Adams
2019-06-25 14:42 ` Lars Ingebrigtsen
2019-06-25 15:33   ` Drew Adams
2019-06-25 15:44     ` Lars Ingebrigtsen
2019-06-25 22:47       ` Michael Heerdegen
2019-06-25 22:53         ` Lars Ingebrigtsen
2019-06-25 23:02           ` Michael Heerdegen
2019-06-25 23:12             ` Lars Ingebrigtsen
2019-06-25 23:26             ` Drew Adams
2019-06-25 23:30               ` Michael Heerdegen
2019-06-26  0:00                 ` Drew Adams
2019-06-26  8:50               ` Andreas Schwab [this message]
2019-06-26 13:32                 ` Drew Adams
2019-06-25 23:17         ` Drew Adams
2019-06-25 23:28           ` Michael Heerdegen
2019-06-25 15:46     ` Lars Ingebrigtsen
2019-06-25 16:06       ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mvmk1d8vigf.fsf@suse.de \
    --to=schwab@suse.de \
    --cc=22457@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    --cc=larsi@gnus.org \
    --cc=michael_heerdegen@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.