From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel Subject: Re: [PATCH v2] Add xwidget webkit support for macOS Cocoa Date: Tue, 04 Jun 2019 10:33:43 +0200 Message-ID: References: <12fa256f-5322-8a47-e8d0-5430e0fef741@cs.ucla.edu> <20190603235121.15533-1-pcr910303@icloud.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="173575"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: eggert@cs.ucla.edu, Sungbin Jo , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 04 10:35:24 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hY4ui-000j2L-9h for ged-emacs-devel@m.gmane.org; Tue, 04 Jun 2019 10:35:24 +0200 Original-Received: from localhost ([127.0.0.1]:48634 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hY4uh-0000Fq-51 for ged-emacs-devel@m.gmane.org; Tue, 04 Jun 2019 04:35:23 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35589) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hY4t9-0008Gy-VE for emacs-devel@gnu.org; Tue, 04 Jun 2019 04:33:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hY4t9-0008DV-32 for emacs-devel@gnu.org; Tue, 04 Jun 2019 04:33:47 -0400 Original-Received: from mx2.suse.de ([195.135.220.15]:59058 helo=mx1.suse.de) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hY4t8-0008CB-TK for emacs-devel@gnu.org; Tue, 04 Jun 2019 04:33:47 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Original-Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 4FBC4AF42; Tue, 4 Jun 2019 08:33:44 +0000 (UTC) X-Yow: Why is it that when you DIE, you can't take your HOME ENTERTAINMENT CENTER with you?? In-Reply-To: (Stefan Monnier's message of "Mon, 03 Jun 2019 22:40:01 -0400") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-Received-From: 195.135.220.15 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237242 Archived-At: On Jun 03 2019, Stefan Monnier wrote: >> (declare-function xwidget-buffer "xwidget.c" (xwidget)) >> (declare-function xwidget-size-request "xwidget.c" (xwidget)) >> (declare-function xwidget-resize "xwidget.c" (xwidget new-width new-height)) >> +;; @callback - Prefer defun to lambda, not to be garbage collected >> +;; before its execution in `xwidget-webkit-callback'. >> (declare-function xwidget-webkit-execute-script "xwidget.c" >> (xwidget script &optional callback)) > > I don't understand this comment. It seems to hint at a GC bug, maybe > because the callback is not registered via `staticpro` or something like that? Could be referring to the situation before commit 8811c2408d. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."