all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: eggert@cs.ucla.edu, Sungbin Jo <pcr910303@icloud.com>,
	emacs-devel@gnu.org
Subject: Re: [PATCH v2] Add xwidget webkit support for macOS Cocoa
Date: Tue, 04 Jun 2019 10:33:43 +0200	[thread overview]
Message-ID: <mvmh89592c8.fsf@suse.de> (raw)
In-Reply-To: <jwvpnnutamj.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Mon, 03 Jun 2019 22:40:01 -0400")

On Jun 03 2019, Stefan Monnier <monnier@iro.umontreal.ca> wrote:

>>  (declare-function xwidget-buffer "xwidget.c" (xwidget))
>>  (declare-function xwidget-size-request "xwidget.c" (xwidget))
>>  (declare-function xwidget-resize "xwidget.c" (xwidget new-width new-height))
>> +;; @callback - Prefer defun to lambda, not to be garbage collected
>> +;; before its execution in `xwidget-webkit-callback'.
>>  (declare-function xwidget-webkit-execute-script "xwidget.c"
>>                    (xwidget script &optional callback))
>
> I don't understand this comment.  It seems to hint at a GC bug, maybe
> because the callback is not registered via `staticpro` or something like that?

Could be referring to the situation before commit 8811c2408d.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."



  reply	other threads:[~2019-06-04  8:33 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-25 13:27 [PATCH] Add xwidget webkit support for macOS Cocoa Sungbin Jo
2019-05-25 17:47 ` Paul Eggert
2019-05-26  2:57   ` 조성빈
2019-05-26  6:02     ` Paul Eggert
2019-05-28 15:07       ` [PATCH v2] " 조성빈
2019-06-02  6:14         ` 조성빈
2019-06-02 14:39           ` Eli Zaretskii
2019-06-03 16:11         ` Alan Third
2019-06-03 17:25           ` Stefan Monnier
2019-06-03 23:36             ` Paul Eggert
2019-06-03 23:51               ` Sungbin Jo
2019-06-04  2:40                 ` Stefan Monnier
2019-06-04  8:33                   ` Andreas Schwab [this message]
2019-06-05  3:06                   ` Sungbin Jo
2019-06-05  3:18                   ` [PATCH v3] " Sungbin Jo
2019-06-05 13:55                     ` Stefan Monnier
2019-06-05 14:34                     ` Eli Zaretskii
2019-06-23 22:38                     ` Alan Third
2019-06-04 16:22                 ` [PATCH v2] " Alan Third
  -- strict thread matches above, loose matches on Subject: below --
2019-05-27  9:50 Sungbin Jo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mvmh89592c8.fsf@suse.de \
    --to=schwab@suse.de \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=pcr910303@icloud.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.