From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.bugs Subject: bug#39596: 26.3; Export INSIDE_EMACS with Eshell Date: Wed, 19 Feb 2020 18:10:06 +0100 Message-ID: References: <87a75lvds8.fsf@ambrevar.xyz> <87blpvc9ek.fsf@ambrevar.xyz> <87y2sylf7p.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="81766"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: Pierre Neidhardt , 39596@debbugs.gnu.org To: Federico Tedin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 19 18:11:21 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j4Ssb-000LAn-19 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 Feb 2020 18:11:21 +0100 Original-Received: from localhost ([::1]:57106 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4Ssa-0005dz-3d for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 Feb 2020 12:11:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47295) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4SsJ-0005Xa-AQ for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2020 12:11:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j4SsI-0007pA-Dc for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2020 12:11:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37358) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j4SsI-0007p2-Af for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2020 12:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j4SsI-0006eb-5c for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2020 12:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Feb 2020 17:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39596 X-GNU-PR-Package: emacs Original-Received: via spool by 39596-submit@debbugs.gnu.org id=B39596.158213221625521 (code B ref 39596); Wed, 19 Feb 2020 17:11:02 +0000 Original-Received: (at 39596) by debbugs.gnu.org; 19 Feb 2020 17:10:16 +0000 Original-Received: from localhost ([127.0.0.1]:43331 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j4SrX-0006dZ-R8 for submit@debbugs.gnu.org; Wed, 19 Feb 2020 12:10:16 -0500 Original-Received: from mx2.suse.de ([195.135.220.15]:34448) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j4SrV-0006dG-Go for 39596@debbugs.gnu.org; Wed, 19 Feb 2020 12:10:14 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Original-Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 6BF48AE24; Wed, 19 Feb 2020 17:10:07 +0000 (UTC) X-Yow: Sign my PETITION. In-Reply-To: <87y2sylf7p.fsf@gmail.com> (Federico Tedin's message of "Wed, 19 Feb 2020 17:22:18 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176254 Archived-At: On Feb 19 2020, Federico Tedin wrote: > Pierre Neidhardt writes: > >> Thanks for looking at this, Federico! >> >> Your patch looks good to me, just one comment below: >> >>> --- a/lisp/eshell/em-dirs.el >>> +++ b/lisp/eshell/em-dirs.el >>> @@ -191,6 +191,9 @@ eshell-dirs-initialize >>> (unless (ring-empty-p eshell-last-dir-ring) >>> (expand-file-name >>> (ring-ref eshell-last-dir-ring 0)))) >>> + t) >>> + ("INSIDE_EMACS" ,(lambda (_indices) >>> + (format "%s,eshell" emacs-version)) >>> t)))) >> >> Why did you unquote the lambda here? > > I need to unquote the lambda to get its value, right? Unquoting allows it to be byte-compiled. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."