From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel Subject: Re: Clarify `pcase' `rx' pattern doc Date: Wed, 13 Jun 2018 09:33:02 +0200 Message-ID: References: <87fu1rqr6m.fsf@web.de> <87a7rzqm11.fsf@web.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1528875107 3326 195.159.176.226 (13 Jun 2018 07:31:47 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 13 Jun 2018 07:31:47 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: Philipp Stephani , Emacs Development To: Michael Heerdegen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 13 09:31:42 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fT0Fq-0000k4-BY for ged-emacs-devel@m.gmane.org; Wed, 13 Jun 2018 09:31:42 +0200 Original-Received: from localhost ([::1]:60423 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fT0Hv-0001da-Mv for ged-emacs-devel@m.gmane.org; Wed, 13 Jun 2018 03:33:51 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41684) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fT0HH-0001cW-0F for emacs-devel@gnu.org; Wed, 13 Jun 2018 03:33:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fT0HD-0004jr-70 for emacs-devel@gnu.org; Wed, 13 Jun 2018 03:33:10 -0400 Original-Received: from mx2.suse.de ([195.135.220.15]:42973) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fT0HD-0004i3-0T for emacs-devel@gnu.org; Wed, 13 Jun 2018 03:33:07 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Original-Received: from relay2.suse.de (charybdis-ext-too.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id D56ACAD57; Wed, 13 Jun 2018 07:33:02 +0000 (UTC) X-Yow: I put aside my copy of ``BOWLING WORLD'' and think about GUN CONTROL legislation.. In-Reply-To: <87a7rzqm11.fsf@web.de> (Michael Heerdegen's message of "Wed, 13 Jun 2018 07:43:22 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Received-From: 195.135.220.15 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:226281 Archived-At: On Jun 13 2018, Michael Heerdegen wrote: > diff --git a/lisp/emacs-lisp/rx.el b/lisp/emacs-lisp/rx.el > index 85e74f28ef..fa2a0898d6 100644 > --- a/lisp/emacs-lisp/rx.el > +++ b/lisp/emacs-lisp/rx.el > @@ -1183,24 +1183,25 @@ rx > > > (pcase-defmacro rx (&rest regexps) > - "Build a `pcase' pattern matching `rx' regexps. > -The REGEXPS are interpreted as by `rx'. The pattern matches if > -the regular expression so constructed matches EXPVAL, as if > -by `string-match'. > + "`pcase' pattern matching strings using `rx' REGEXPS. This sentence no verb. What's wrong with the original version? At least it should start with a capitalized word. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."