From: Andreas Schwab <schwab@suse.de>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: Philipp Stephani <phst@google.com>,
Emacs Development <emacs-devel@gnu.org>
Subject: Re: Clarify `pcase' `rx' pattern doc
Date: Wed, 13 Jun 2018 09:33:02 +0200 [thread overview]
Message-ID: <mvmd0wvdtu9.fsf@suse.de> (raw)
In-Reply-To: <87a7rzqm11.fsf@web.de> (Michael Heerdegen's message of "Wed, 13 Jun 2018 07:43:22 +0200")
On Jun 13 2018, Michael Heerdegen <michael_heerdegen@web.de> wrote:
> diff --git a/lisp/emacs-lisp/rx.el b/lisp/emacs-lisp/rx.el
> index 85e74f28ef..fa2a0898d6 100644
> --- a/lisp/emacs-lisp/rx.el
> +++ b/lisp/emacs-lisp/rx.el
> @@ -1183,24 +1183,25 @@ rx
>
>
> (pcase-defmacro rx (&rest regexps)
> - "Build a `pcase' pattern matching `rx' regexps.
> -The REGEXPS are interpreted as by `rx'. The pattern matches if
> -the regular expression so constructed matches EXPVAL, as if
> -by `string-match'.
> + "`pcase' pattern matching strings using `rx' REGEXPS.
This sentence no verb. What's wrong with the original version? At
least it should start with a capitalized word.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2018-06-13 7:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 3:52 Clarify `pcase' `rx' pattern doc Michael Heerdegen
2018-06-13 5:43 ` Michael Heerdegen
2018-06-13 7:33 ` Andreas Schwab [this message]
2018-06-13 7:59 ` Michael Heerdegen
2018-06-13 8:18 ` Michael Heerdegen
2018-06-13 12:29 ` Yuri Khan
2018-06-18 12:34 ` Michael Heerdegen
2018-06-18 14:11 ` Stefan Monnier
2018-06-18 14:58 ` Michael Heerdegen
2018-06-18 16:56 ` Eli Zaretskii
2018-06-18 17:22 ` Michael Heerdegen
2018-06-18 17:55 ` Eli Zaretskii
2018-06-21 11:13 ` Michael Heerdegen
2018-06-21 14:48 ` Eli Zaretskii
2018-06-21 15:13 ` Michael Heerdegen
2018-06-23 13:35 ` Eli Zaretskii
2018-07-06 17:57 ` Michael Heerdegen
2018-07-07 6:53 ` Eli Zaretskii
2018-07-07 13:36 ` Michael Heerdegen
2018-07-07 13:57 ` Eli Zaretskii
2018-07-07 14:35 ` Michael Heerdegen
2018-07-20 8:45 ` Eli Zaretskii
2018-07-20 22:56 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmd0wvdtu9.fsf@suse.de \
--to=schwab@suse.de \
--cc=emacs-devel@gnu.org \
--cc=michael_heerdegen@web.de \
--cc=phst@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.