all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Returning argument string (regexp-quote)
Date: Tue, 24 Sep 2019 13:49:21 +0200	[thread overview]
Message-ID: <mvm7e5xewxq.fsf@suse.de> (raw)
In-Reply-To: <A90CD4DB-8798-439E-AC8E-7EFE2CF4CEDF@acm.org> ("Mattias Engdegård"'s message of "Tue, 24 Sep 2019 13:28:15 +0200")

On Sep 24 2019, Mattias Engdegård <mattiase@acm.org> wrote:

> diff --git a/src/search.c b/src/search.c
> index 1e57d2ecbe..fc9b85f413 100644
> --- a/src/search.c
> +++ b/src/search.c
> @@ -3138,10 +3138,12 @@ DEFUN ("regexp-quote", Fregexp_quote, Sregexp_quote, 1, 1, 0,
>      }
>  
>    Lisp_Object result
> -    = make_specified_string (temp,
> -			     SCHARS (string) + backslashes_added,
> -			     out - temp,
> -			     STRING_MULTIBYTE (string));
> +    = (out - temp > SBYTES (string)

          backslashes_added > 0

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."



  reply	other threads:[~2019-09-24 11:49 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-24 11:28 Returning argument string (regexp-quote) Mattias Engdegård
2019-09-24 11:49 ` Andreas Schwab [this message]
2019-09-24 16:20 ` Eli Zaretskii
2019-09-24 17:44   ` Mattias Engdegård
2019-09-24 18:24     ` Paul Eggert
2019-09-24 19:47     ` Eli Zaretskii
2019-09-25 13:41       ` Mattias Engdegård
2019-09-25 15:08         ` Eli Zaretskii
2019-09-25 19:55           ` Compilation failure on macOS 10.15 Catalina Zach Pearson
2019-09-25 20:29             ` mituharu
2019-09-25 21:55               ` Zach Pearson
2019-09-25 22:47                 ` mituharu
2019-09-25 23:07                   ` Zach Pearson
2019-09-25 23:39                     ` mituharu
2019-09-27 23:22                     ` chad
2019-10-02  3:59                       ` Zach Pearson
2019-10-02  4:04                         ` YAMAMOTO Mitsuharu
2019-10-02  4:34                           ` Zach Pearson
2019-10-02  4:42                             ` YAMAMOTO Mitsuharu
2019-10-02  4:43                               ` Zach Pearson
2019-10-02  5:00                                 ` YAMAMOTO Mitsuharu
2019-10-02  5:07                                   ` Zach Pearson
2019-10-02  7:43                                   ` Zach Pearson
2019-10-02 15:15                                     ` Xu Xin
2019-09-26  8:34             ` Robert Pluim
2019-09-26 16:05               ` Zach Pearson
2019-09-26 21:00                 ` mituharu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mvm7e5xewxq.fsf@suse.de \
    --to=schwab@suse.de \
    --cc=emacs-devel@gnu.org \
    --cc=mattiase@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.