bug#8554: 24.0.50; compiler warning after make-local-variable

bug#8554: 24.0.50; compiler warning after make-local-variable

[Andreas Röhler]

emacs -q:

When `M-x byte-compile-file' the following form,

(defun highlight-indentation-on ()
   "Make sure `highlight-indentation' is on. "
   (interactive)
   (set (make-local-variable 'highlight-indent-active) nil)
   (highlight-indentation)
   (when (called-interactively-p 'any)
     (message "highlight-indentation ON")))

receive a warning saying:

In highlight-indentation-on:
highlight-indentation.el:47:55:Warning: assignment to free variable
     `highlight-indent-active'

That's not useful IMHO, as `make-local-variable' is explicit already.

Thanks


Andreas

--
https://code.launchpad.net/~a-roehler/python-mode/components-python-mode
https://code.launchpad.net/s-x-emacs-werkstatt/


In GNU Emacs 24.0.50.1 (i686-pc-linux-gnu, GTK+ Version 2.18.6)
  of 2011-03-04 on localhost
Windowing system distributor `The X.Org Foundation', version 11.0.10605000
configured using `configure  '--without-makeinfo' 'CFLAGS=-g -O2 
-fno-optimize-sibling-calls''

Important settings:
   value of $LC_ALL: nil
   value of $LC_COLLATE: nil
   value of $LC_CTYPE: nil
   value of $LC_MESSAGES: nil
   value of $LC_MONETARY: nil
   value of $LC_NUMERIC: nil
   value of $LC_TIME: nil
   value of $LANG: de_DE.UTF-8
   value of $XMODIFIERS: @im=local
   locale-coding-system: utf-8-unix
   default enable-multibyte-characters: t

Major mode: Emacs-Lisp

Minor modes in effect:
   tooltip-mode: t
   mouse-wheel-mode: t
   tool-bar-mode: t
   menu-bar-mode: t
   file-name-shadow-mode: t
   global-font-lock-mode: t
   font-lock-mode: t
   blink-cursor-mode: t
   auto-composition-mode: t
   auto-encryption-mode: t
   auto-compression-mode: t
   line-number-mode: t
   transient-mark-mode: t

Recent input:
<help-echo> C-x d <help-echo> C-x d <up> <up> <down>
<help-echo> <help-echo> <down-mouse-1> <mouse-1> C-x
d <down> <down> <down> M-> M-> C-x C-f <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<backspace> <backspace> <backspace> <backspace> <backspace>
<backspace> <backspace> <backspace> <backspace> <backspace>
<backspace> <backspace> <backspace> <backspace> <backspace>
<backspace> <backspace> <backspace> a r b <tab> e <tab>
m <tab> / p y h t <backspace> <backspace> t <tab> <return>
M-> C-r c o m p o C-r C-r <up> <up> d d x y e s <return>
y e s <return> <return> M-> C-r h i g h l C-r C-r <up>
<up> <return> M-x b y t e - c o m p i <tab> <return>
<return> C-x o C-x 1 <down> <down> <down> <down> <down>
<return> M-x r e p o r t - e m a c s - b u <tab> <
return>

Recent messages:
Mark set [2 times]
Making completion list...
Mark set
Mark saved where search started
Deleting...done
Mark set
Mark saved where search started
Compiling /MY_PATH../highlight-indentation.el...done
Wrote /MY_PATH../highlight-indentation.elc
Mark set

Load-path shadows:
None found.

Features:
(shadow sort mail-extr message sendmail rfc822 mml mml-sec mm-decode
mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums
mailabbrev mail-utils gmm-utils mailheader emacsbug url-util url-parse
auth-source eieio assoc gnus-util time-date password-cache url-vars
mm-util mail-prsvr warnings byte-opt compile comint ring bytecomp
byte-compile vc-rcs multi-isearch dired-aux help-mode easymenu view
dired regexp-opt tooltip ediff-hook vc-hooks lisp-float-type mwheel
x-win x-dnd tool-bar dnd fontset image fringe lisp-mode register page
menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core frame cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev loaddefs button
minibuffer faces cus-face files text-properties overlay md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote make-network-process dbusbind dynamic-setting
system-font-setting font-render-setting move-toolbar gtk x-toolkit x
multi-tty emacs)

bug#8554: 24.0.50; compiler warning after make-local-variable

[Andreas Röhler]

Hi,

correcting the report:

the error occurs, if the following form is present:

(defun highlight-indentation (&optional indent-width)
   "Toggle highlight indentation.
Optional argument INDENT-WIDTH specifies which indentation
level (spaces only) should be highlighted, if omitted
indent-width will be guessed from current major-mode"
   (interactive "P")
   (let ((re (format "\\( \\) \\{%s\\}" (- highlight-indent-offset 1))))
     (if (not highlight-indent-active)

...

The bug so far only pertains to the wrong place, the warning points to.

Seems a minor bug..

Thanks

Andreas

bug#8554: 24.0.50; compiler warning after make-local-variable

[Glenn Morris]

If you want to avoid warnings about free variables, declare them with
defvars.