Block as method parameter indentation in objc-mode

Block as method parameter indentation in objc-mode

[juha.nieminen]

Is there an easy way in objc-mode to make a starting { symbol that appears in a method parameter to be indented only one space more than the starting [ of the method call? In other words, I want it to indent like this:

    [someObj someMethodTakingABlock: ^()
     {
         // some code here
     }];

Likewise, if possible, the ^(...) part also ought to be indented like that if it's on its own like. So like:

    [someObj someMethodTakingABlock:
     ^(int someValue, NSString* someString)
     {
         // some code here
     }];

Currently objc-mode indents such blocks waaaay to the right, which is rather impractical.

If there happened to be more parameters after that, they ought to be indented as normal. In other words, overall, like this:

    [someObj someParameter: aValue
                    aBlock: ^()
     {
         // some code
     }
           aThirdParameter: anotherValue];

Re: Block as method parameter indentation in objc-mode

[Pascal J. Bourguignon]

juha.nieminen@gmail.com writes:

> Is there an easy way in objc-mode to make a starting { symbol that appears in a method parameter to be indented only one space more than the starting [ of the method call? In other words, I want it to indent like this:
>
>     [someObj someMethodTakingABlock: ^()
>      {
>          // some code here
>      }];
>
> Likewise, if possible, the ^(...) part also ought to be indented like that if it's on its own like. So like:
>
>     [someObj someMethodTakingABlock:
>      ^(int someValue, NSString* someString)
>      {
>          // some code here
>      }];
>
> Currently objc-mode indents such blocks waaaay to the right, which is rather impractical.

It's the objc-method-call-cont c-offsets-alist key.

My current setting, giving the same results you have is:

       (objc-method-call-cont . (c-lineup-ObjC-method-call-colons
                                 c-lineup-ObjC-method-call
                                 +))

to obtain what you want, you would have to modify it, but as you can
see, it uses those two functions to compute the position in a
sophisticated way.



By using:

/*
    (push '(objc-method-call-cont . (c-lineup-ObjC-method-call-colons
                                     ;; c-lineup-ObjC-method-call
                                     2)) 
            c-offsets-alist)
*/

we obtain this:

    [someObj someMethodTakingABlock: ^()
      {
          // some code here
      }];

    [someObj someMethodTakingABlock:
      ^(int someValue, NSString* someString)
      {
          // some code here
      }];

but also:

    [someObj someMethodTakingABlock: 
      a 
                          someOther:b];

which may not be what you want.   In that case, you might have to write
a function to replace c-lineup-ObjC-method-call providing the same
indent as c-lineup-ObjC-method-call for non-^ and non-{, and providing
the 2-indent for ^ and {.

> If there happened to be more parameters after that, they ought to be
> indented as normal. In other words, overall, like this:

and indeed, indenting correctly:

    [someObj someParameter: aValue
                    aBlock: ^()
      {
          // some code
      }
    aThirdParameter: anotherValue];

is harder.  As it is, aThirdParameter: is taken as a label, instead of
an objc-method-call-cont.


-- 
__Pascal Bourguignon__                 http://www.informatimago.com/
“The factory of the future will have only two employees, a man and a
dog. The man will be there to feed the dog. The dog will be there to
keep the man from touching the equipment.” -- Carl Bass CEO Autodesk

Re: Block as method parameter indentation in objc-mode

[juha.nieminen]

On Monday, May 25, 2015 at 9:30:23 PM UTC+3, Pascal J. Bourguignon wrote:
> By using:
> 
> /*
>     (push '(objc-method-call-cont . (c-lineup-ObjC-method-call-colons
>                                      ;; c-lineup-ObjC-method-call
>                                      2)) 
>             c-offsets-alist)
> */

I'm not sure where this should be put. If I add it to my .emacs, it issues the error "Symbol's value as variable is void: c-offsets-alist".

Re: Block as method parameter indentation in objc-mode

[Pascal J. Bourguignon]

juha.nieminen@gmail.com writes:

> On Monday, May 25, 2015 at 9:30:23 PM UTC+3, Pascal J. Bourguignon wrote:
>> By using:
>> 
>> /*
>>     (push '(objc-method-call-cont . (c-lineup-ObjC-method-call-colons
>>                                      ;; c-lineup-ObjC-method-call
>>                                      2)) 
>>             c-offsets-alist)
>> */
>
> I'm not sure where this should be put. If I add it to my .emacs, it
> issues the error "Symbol's value as variable is void:
> c-offsets-alist".

There's various ways to configure c styles.
(info "(emacs) Custom C Indent")


-- 
__Pascal Bourguignon__                 http://www.informatimago.com/
“The factory of the future will have only two employees, a man and a
dog. The man will be there to feed the dog. The dog will be there to
keep the man from touching the equipment.” -- Carl Bass CEO Autodesk

Re: Block as method parameter indentation in objc-mode

[Juha Nieminen]

Pascal J. Bourguignon <pjb@informatimago.com> wrote:
> juha.nieminen@gmail.com writes:
> 
>> On Monday, May 25, 2015 at 9:30:23 PM UTC+3, Pascal J. Bourguignon wrote:
>>> By using:
>>> 
>>> /*
>>>     (push '(objc-method-call-cont . (c-lineup-ObjC-method-call-colons
>>>                                      ;; c-lineup-ObjC-method-call
>>>                                      2)) 
>>>             c-offsets-alist)
>>> */
>>
>> I'm not sure where this should be put. If I add it to my .emacs, it
>> issues the error "Symbol's value as variable is void:
>> c-offsets-alist".
> 
> There's various ways to configure c styles.
> (info "(emacs) Custom C Indent")

I have no idea what to do with that information. I still haven't the
slightest clue where I should put that command.

--- news://freenews.netfront.net/ - complaints: news@netfront.net ---

Re: Block as method parameter indentation in objc-mode

[John Mastro]

Juha Nieminen <nospam@thanks.invalid> wrote:
>>>> /*
>>>>     (push '(objc-method-call-cont . (c-lineup-ObjC-method-call-colons
>>>>                                      ;; c-lineup-ObjC-method-call
>>>>                                      2))
>>>>             c-offsets-alist)
>>>> */
> I have no idea what to do with that information. I still haven't the
> slightest clue where I should put that command.

Try this:

(eval-after-load 'cc-mode
  '(push '(objc-method-call-cont . (c-lineup-ObjC-method-call-colons
                                    ;; c-lineup-ObjC-method-call
                                    2))
         c-offsets-alist))

That wraps Pascal's suggestion in `eval-after-load' such that it's not
evaluated until after `cc-mode' is loaded.

-- 
john

Re: Block as method parameter indentation in objc-mode

[Juha Nieminen]

John Mastro <john.b.mastro@gmail.com> wrote:
> Try this:
> 
> (eval-after-load 'cc-mode
>  '(push '(objc-method-call-cont . (c-lineup-ObjC-method-call-colons
>                                    ;; c-lineup-ObjC-method-call
>                                    2))
>         c-offsets-alist))
> 
> That wraps Pascal's suggestion in `eval-after-load' such that it's not
> evaluated until after `cc-mode' is loaded.

That seems to work. Thanks.

As he said, if there's any additional parameter after the {} block,
emacs will consider it a label rather than a paraneter, and mis-indent
(and mis-color) it. Fortunately it's very are for methods to be designed
like this. I suppose I'll cope (unless someone can suggest a fix to that.)

--- news://freenews.netfront.net/ - complaints: news@netfront.net ---