HEAD broken for OSX- nsfsn.o fails to compile

HEAD broken for OSX- nsfsn.o fails to compile

[Randal L. Schwartz]

Last edit that touched this was Chong Yidong, on Mar 29.  Does
this ring any bells?

'
/System/Library/Frameworks/AppKit.framework/Headers/NSInputManager.h:23:
warning: previous declaration of '-(NSInteger)conversationIdentifier'
nsterm.m: In function '-[EmacsScroller judge]':
nsterm.m:5761: warning: ISO C90 forbids mixed declarations and code
gcc -c  -Demacs -DHAVE_CONFIG_H
-I. -I/Users/merlyn/MIRROR/emacs-GIT/src -Dtemacs     -g -O2
-Wdeclaration-after-statement -Wno-pointer-sign   -MMD -MF deps/nsfns.d
nsfns.m
nsfns.m: In function 'ns_get_screen':
nsfns.m:227: warning: assignment makes pointer from integer without a
cast
nsfns.m: At top level:
nsfns.m:690: error: conflicting types for 'ns_set_doc_edited'
nsterm.h:712: error: previous declaration of 'ns_set_doc_edited' was
here
nsfns.m: In function 'Fx_display_color_cells':
nsfns.m:2377: warning: ISO C90 forbids mixed declarations and code
make[1]: *** [nsfns.o] Error 1
make: *** [src] Error 2

-- 
Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
<merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/>
Smalltalk/Perl/Unix consulting, Technical writing, Comedy, etc. etc.
See http://methodsandmessages.vox.com/ for Smalltalk and Seaside discussion

Re: HEAD broken for OSX- nsfsn.o fails to compile

[Randal L. Schwartz]

>>>>> "Randal" == Randal L Schwartz <merlyn@stonehenge.com> writes:

Randal> Last edit that touched this was Chong Yidong, on Mar 29.  Does
Randal> this ring any bells?

Yup, just bisected... that's the one that breaks it.

Author: Chong Yidong <cyd@stupidchicken.com>
Date:   Mon Mar 29 19:48:44 2010 -0400

    Clean up unneeded ns_set_icon_type calls.
    
    Patch from Adrian Robert, see
    http://lists.gnu.org/archive/html/emacs-devel/2010-03/msg01391.html
    
    * xdisp.c (x_consider_frame_title, update_window_cursor): Remove
    HAVE_NS conditionals.
    (prepare_menu_bars)[HAVE_NS]: Call ns_set_doc_edited.
    
    * nsfns.m (x_implicitly_set_name): If frame-title-format is t, use
    filename for the title.
    (ns_set_doc_edited): Do nothing if the selected window is a
    minibuffer window.
    
    * nsterm.h: Add prototypes for ns_set_name_as_filename and
    ns_set_doc_edited.
    
    * nsterm.m: Remove unneeded prototype.

-- 
Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
<merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/>
Smalltalk/Perl/Unix consulting, Technical writing, Comedy, etc. etc.
See http://methodsandmessages.vox.com/ for Smalltalk and Seaside discussion

Re: HEAD broken for OSX- nsfsn.o fails to compile

[Glenn Morris]

Randal L. Schwartz wrote:

> Does this ring any bells?

Well, it rings these bells:

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=5814
http://lists.gnu.org/archive/html/emacs-devel/2010-03/msg01440.html

and the one from INSTALL.BZR:

    Because the Bazaar version of Emacs is a work in progress, it will
    sometimes fail to build. Please wait a day or so (and check the
    bug and development mailing list archives) before reporting such
    problems. In most cases, the problem is known about and is just
    waiting for someone to fix it.

Re: HEAD broken for OSX- nsfsn.o fails to compile

[Chad Brown]

On Mar 31, 2010, at 3:23 PM, Glenn Morris wrote:

> Randal L. Schwartz wrote:
> 
>> Does this ring any bells?
> 
> Well, it rings these bells:
> 
> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=5814
> http://lists.gnu.org/archive/html/emacs-devel/2010-03/msg01440.html
> 
> and the one from INSTALL.BZR:
> 
>    Because the Bazaar version of Emacs is a work in progress, it will
>    sometimes fail to build. Please wait a day or so (and check the
>    bug and development mailing list archives) before reporting such
>    problems. In most cases, the problem is known about and is just
>    waiting for someone to fix it.

You reply to the message wherein he points out that the breakage happened 3 days ago with a quote suggesting he wait a day or so.  He checked the mailing list and saw that no one had mentioned it in well more than ``a day or so'', and sent mail to the development list with the specific breakage and changeset that caused it.  

Complete Failure.

I realize that it is very important to you that the bug tracker be used appropriately, but this is not the first time I've seen you attempt to hector people out of reporting development issues and asking development questions on the development list -- not the bug tracker.  While I'm sure that you're doing good work, and I do appreciate those good works, I do not consider this type of nanny-ism good, or desirable, and it comes across to me as the opposite of helpful.

Thanks,
*Chad

Re: HEAD broken for OSX- nsfsn.o fails to compile

[Chong Yidong]

Chad Brown <yandros@MIT.EDU> writes:

> I realize that it is very important to you that the bug tracker be
> used appropriately, but this is not the first time I've seen you
> attempt to hector people out of reporting development issues and
> asking development questions on the development list -- not the bug
> tracker.

It's not possible to entirely avoid duplication on the mailing lists,
and perhaps Glenn was shorter than he should have been, but this issue
*was* being discussed on emacs-devel, in the thread

  http://lists.gnu.org/archive/html/emacs-devel/2010-03/msg01298.html

Re: HEAD broken for OSX- nsfsn.o fails to compile

[Chad Brown]

On Mar 31, 2010, at 5:54 PM, Chong Yidong wrote:

> Chad Brown <yandros@MIT.EDU> writes:
> 
>> I realize that it is very important to you that the bug tracker be
>> used appropriately, but this is not the first time I've seen you
>> attempt to hector people out of reporting development issues and
>> asking development questions on the development list -- not the bug
>> tracker.
> 
> It's not possible to entirely avoid duplication on the mailing lists,
> and perhaps Glenn was shorter than he should have been, but this issue
> *was* being discussed on emacs-devel, in the thread
> 
>  http://lists.gnu.org/archive/html/emacs-devel/2010-03/msg01298.html

Huh; I've been reading that thread and didn't see anything on it about breaking the build since Monday.   

...which sounds like sarcasm when I re-read it, but it wasn't intended to be -- I seriously have been reading that thread, and while I assumed that it was the motivator for the changes that caused the breakage, I hadn't seen anything in it about the build being broken on macosx.  Did you really already know, or did you learn of it from Randal's message?

*Chad