From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: master 491531b: Avoid ert test failures Date: Wed, 19 Apr 2017 16:38:47 -0400 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1492634348 24597 195.159.176.226 (19 Apr 2017 20:39:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 19 Apr 2017 20:39:08 +0000 (UTC) User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) Cc: Emacs developers To: Noam Postavsky Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 19 22:39:03 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d0wNR-00068z-Gu for ged-emacs-devel@m.gmane.org; Wed, 19 Apr 2017 22:39:01 +0200 Original-Received: from localhost ([::1]:50317 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d0wNU-0008I5-0Y for ged-emacs-devel@m.gmane.org; Wed, 19 Apr 2017 16:39:04 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38660) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d0wNL-0008GW-CW for emacs-devel@gnu.org; Wed, 19 Apr 2017 16:38:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d0wNK-0008CA-NS for emacs-devel@gnu.org; Wed, 19 Apr 2017 16:38:55 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53143) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d0wND-00089u-J9; Wed, 19 Apr 2017 16:38:47 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1d0wND-0001Sx-54; Wed, 19 Apr 2017 16:38:47 -0400 X-Spook: quarter CISU United Nations computer terrorism anthrax X-Ran: vh~])>F">~e:Ajwh=0hj#DF\Bj"S0_!!N (Noam Postavsky's message of "Tue, 18 Apr 2017 22:35:56 -0400") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214140 Archived-At: Noam Postavsky wrote: >> + (require 'bytecomp) ; FIXME? > > Anyway, I was considering fixing this by using (bound-and-true-p > byte-compile-macro-environment) instead of loading `bytecomp', which > almost seems to work except that eval-tests--bugs-24912-and-24913 > fails because `should-error' fails to catch the error from > byte-compile. That can be fixed by adding (require 'bytecomp) in that > test, but maybe it's better just to leave the require in ert? > > 1: 2016-12-06 22:20:23 -0500 58e418d2ceb82501f03d9c3316fd0a46faf7f0eb > Fix ert-tests when running compiled The above was just a workaround I threw in to stop the test failures. I think explicitly loading bytecomp isn't great, and would welcome any better solution. Maybe the original tests that caused this issue simply aren't sensible.