From: Glenn Morris <rgm@gnu.org>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: master 491531b: Avoid ert test failures
Date: Wed, 19 Apr 2017 16:38:47 -0400 [thread overview]
Message-ID: <mbvaq0t9ns.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <CAM-tV--EZ=ZXYvCxQnCKZJYQK-Z63jZ5webCOx7pd98E4Cmitg@mail.gmail.com> (Noam Postavsky's message of "Tue, 18 Apr 2017 22:35:56 -0400")
Noam Postavsky wrote:
>> + (require 'bytecomp) ; FIXME?
>
> Anyway, I was considering fixing this by using (bound-and-true-p
> byte-compile-macro-environment) instead of loading `bytecomp', which
> almost seems to work except that eval-tests--bugs-24912-and-24913
> fails because `should-error' fails to catch the error from
> byte-compile. That can be fixed by adding (require 'bytecomp) in that
> test, but maybe it's better just to leave the require in ert?
>
> 1: 2016-12-06 22:20:23 -0500 58e418d2ceb82501f03d9c3316fd0a46faf7f0eb
> Fix ert-tests when running compiled
The above was just a workaround I threw in to stop the test failures.
I think explicitly loading bytecomp isn't great, and would welcome
any better solution. Maybe the original tests that caused this issue
simply aren't sensible.
next prev parent reply other threads:[~2017-04-19 20:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 2:35 master 491531b: Avoid ert test failures Noam Postavsky
2017-04-19 20:38 ` Glenn Morris [this message]
2017-04-23 3:23 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mbvaq0t9ns.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.