Re: bug? the position of scroll-bar

[storm@cua.dk (Kim F. Storm)]

Masatake YAMATO <jet@gyve.org> writes:

> > >     A width of nil and type of t means to use the frame's corresponding value.

> Thank you. I've validated more strictly.

That's too much now :-)

The doc string is unclear.  What it's supposed to say is:

If WIDTH is nil, use the frame's scroll-bar width.
If TYPE is t, use the frame's scroll-bar type.


So just allow type = t with no check on width...
And fix the doc string :-)



> How about this one?
> 
> 2003-09-22  Masatake YAMATO  <jet@gyve.org>
> 
> 	* window.c (Fset_window_scroll_bars): Validate the value of 
> 	`vertical_type'.
> 
> Index: src/window.c
> ===================================================================
> RCS file: /cvsroot/emacs/emacs/src/window.c,v
> retrieving revision 1.447
> diff -u -r1.447 window.c
> --- src/window.c	20 Sep 2003 23:38:54 -0000	1.447
> +++ src/window.c	22 Sep 2003 09:18:19 -0000
> @@ -5873,6 +5873,12 @@
>    if (XINT (width) == 0)
>      vertical_type = Qnil;
>  
> +  if (!(EQ (vertical_type, Qnil)
> +	|| EQ (vertical_type, Qleft) 
> +	|| EQ (vertical_type, Qright)
> +	|| (EQ (vertical_type, Qt) && NILP (width))))
> +    error ("Invalid type of vertical scroll bar");
> +
>    if (!EQ (w->scroll_bar_width, width)
>        || !EQ (w->vertical_scroll_bar_type, vertical_type))
>      {
> 
> 

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk