From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Barry Fishman Newsgroups: gmane.emacs.devel Subject: Re: x86_64 problems/fix (was: alloc.c problem when GC_MARK_STACK is GC_USE_GCPROS_AS_BEFORE) Date: Mon, 12 Jul 2004 10:24:51 -0400 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1089642271 8088 80.91.224.253 (12 Jul 2004 14:24:31 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 12 Jul 2004 14:24:31 +0000 (UTC) Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Mon Jul 12 16:23:55 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1Bk1il-0003FC-00 for ; Mon, 12 Jul 2004 16:23:55 +0200 Original-Received: from lists.gnu.org ([199.232.76.165]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1Bk1ik-0003zj-00 for ; Mon, 12 Jul 2004 16:23:54 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Bk1l4-0007M8-M3 for emacs-devel@quimby.gnus.org; Mon, 12 Jul 2004 10:26:18 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1Bk1l0-0007KJ-1k for emacs-devel@gnu.org; Mon, 12 Jul 2004 10:26:14 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1Bk1kx-0007Ji-VV for emacs-devel@gnu.org; Mon, 12 Jul 2004 10:26:13 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Bk1kx-0007JR-Sm for emacs-devel@gnu.org; Mon, 12 Jul 2004 10:26:11 -0400 Original-Received: from [80.91.224.249] (helo=main.gmane.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Bk1i1-0008Nw-L5 for emacs-devel@gnu.org; Mon, 12 Jul 2004 10:23:09 -0400 Original-Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 1Bk1hz-0006Tv-00 for ; Mon, 12 Jul 2004 16:23:07 +0200 Original-Received: from 30.orlando-11-13rs.fl.dial-access.att.net ([12.78.48.30]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 12 Jul 2004 16:23:07 +0200 Original-Received: from barry_fishman by 30.orlando-11-13rs.fl.dial-access.att.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 12 Jul 2004 16:23:07 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-To: emacs-devel@gnu.org Original-Lines: 60 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: 30.orlando-11-13rs.fl.dial-access.att.net User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.3.50 (gnu/linux) Cancel-Lock: sha1:/lhWfGq0JSver3TYQ3HPMmag3CQ= X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:25618 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:25618 storm@cua.dk (Kim F. Storm) writes: > Barry Fishman writes: > >> I was unable to make any change to alloc.c that would fix the GC_MARK_STACK >> problem without later crashes in the build while compiling the lisp >> files. > > Does the following patch work (if you undo the patch you suggested below)? > [patch skipped] That was my first attempt at fixing the problem. The emacs (bootstrap) build then failed later on during a lisp compile. I could not diagnose what was causing it, but at the time assumed it was a garbage collector problem. Trying it again I get the following during a bootstrap build: In completion-c-mode-hook: completion.el:2354:15:Warning: reference to free variable `c-mode-map' In completion-setup-fortran-mode: completion.el:2364:15:Warning: reference to free variable `fortran-mode-map' Wrote /home/barry/src/gen/emacs/lisp/completion.elc Compiling /home/barry/src/gen/emacs/lisp/./composite.el Wrote /home/barry/src/gen/emacs/lisp/composite.elc Compiling /home/barry/src/gen/emacs/lisp/./cus-dep.el Wrote /home/barry/src/gen/emacs/lisp/cus-dep.elc Compiling /home/barry/src/gen/emacs/lisp/./cus-edit.el Wrote /home/barry/src/gen/emacs/lisp/cus-edit.elc Compiling /home/barry/src/gen/emacs/lisp/./cus-face.el Wrote /home/barry/src/gen/emacs/lisp/cus-face.elc Compiling /home/barry/src/gen/emacs/lisp/./cus-start.el Wrote /home/barry/src/gen/emacs/lisp/cus-start.elc Compiling /home/barry/src/gen/emacs/lisp/./cus-theme.el Fatal error (11)make[1]: *** [compile] Error 1 make[1]: Leaving directory `/home/barry/src/gen/emacs/lisp' make: *** [bootstrap] Error 2 >> However, I suspect the attached change to src/s/gnu-linux.h is >> approprate. This produces a working emacs (for me) on a amd64 >> gnu-linux system (SuSE 9.1), although it sidesteps the problem in >> alloc.c. > > This is a good change -- have you been using that for some time > now without problems? If so, I will commit your patch. I have been using it since July 6 without problems. Am I the only one using emacs on a amd64 gnu-linux kernel? I used the __amd64__ C define to identify the x86_64 processor. Under SuSE 9.1 (gcc 3.3.3) __x86_64__ is also automatically defined. I don't know if there is any advantage in picking one over the other. The rest of the emacs sources does not seem to make this check although the src/m/amdx86-64.h file wrongly declares that __x86_64 is defined automatically. -- Barry Fishman