* font-lock-negation-char-face
@ 2005-05-06 22:32 Stefan Monnier
2005-05-07 6:15 ` font-lock-negation-char-face Henrik Enberg
0 siblings, 1 reply; 10+ messages in thread
From: Stefan Monnier @ 2005-05-06 22:32 UTC (permalink / raw)
Let me just say that I find this new "feature" dubious.
- it makes things even more "angry fruit salad" and thus requires
yet more tweaking to make the text legible again.
- it's unclear that these specific chars are particular sources of errors.
- why not have a more generic name like font-lock-important-detail-face,
so it's at least not so absurdly narrow-scoped.
Stefan "who's not interested in more lexical highlighting,
as opposed to syntactic hilighting"
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: font-lock-negation-char-face
2005-05-06 22:32 font-lock-negation-char-face Stefan Monnier
@ 2005-05-07 6:15 ` Henrik Enberg
2005-05-07 9:57 ` font-lock-negation-char-face Eli Zaretskii
0 siblings, 1 reply; 10+ messages in thread
From: Henrik Enberg @ 2005-05-07 6:15 UTC (permalink / raw)
Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> Let me just say that I find this new "feature" dubious.
> - it makes things even more "angry fruit salad" and thus requires
> yet more tweaking to make the text legible again.
> - it's unclear that these specific chars are particular sources of errors.
> - why not have a more generic name like font-lock-important-detail-face,
> so it's at least not so absurdly narrow-scoped.
Indeed, I find that it makes my code much harder to read. The choice of
a bold face as default is especially bad. And as you say, I don't
really think people write !foo erroneously all that often.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: font-lock-negation-char-face
2005-05-07 6:15 ` font-lock-negation-char-face Henrik Enberg
@ 2005-05-07 9:57 ` Eli Zaretskii
2005-05-07 20:17 ` font-lock-negation-char-face Kim F. Storm
2005-05-08 9:03 ` font-lock-negation-char-face Richard Stallman
0 siblings, 2 replies; 10+ messages in thread
From: Eli Zaretskii @ 2005-05-07 9:57 UTC (permalink / raw)
> From: Henrik Enberg <henrik.enberg@telia.com>
> Date: Sat, 07 May 2005 08:15:59 +0200
> Cc: emacs-devel@gnu.org
>
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
> > Let me just say that I find this new "feature" dubious.
> > - it makes things even more "angry fruit salad" and thus requires
> > yet more tweaking to make the text legible again.
> > - it's unclear that these specific chars are particular sources of errors.
> > - why not have a more generic name like font-lock-important-detail-face,
> > so it's at least not so absurdly narrow-scoped.
>
> Indeed, I find that it makes my code much harder to read. The choice of
> a bold face as default is especially bad. And as you say, I don't
> really think people write !foo erroneously all that often.
Let me join the choir and say that the effect of this change is
unpleasant at best, IMO. I think this new feature should be at least
turned off by default, if not removed.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: font-lock-negation-char-face
2005-05-07 9:57 ` font-lock-negation-char-face Eli Zaretskii
@ 2005-05-07 20:17 ` Kim F. Storm
2005-05-08 22:40 ` font-lock-negation-char-face Juanma Barranquero
2005-05-08 9:03 ` font-lock-negation-char-face Richard Stallman
1 sibling, 1 reply; 10+ messages in thread
From: Kim F. Storm @ 2005-05-07 20:17 UTC (permalink / raw)
Cc: emacs-devel
"Eli Zaretskii" <eliz@gnu.org> writes:
>> From: Henrik Enberg <henrik.enberg@telia.com>
>> Date: Sat, 07 May 2005 08:15:59 +0200
>> Cc: emacs-devel@gnu.org
>>
>> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>
>> > Let me just say that I find this new "feature" dubious.
>> > - it makes things even more "angry fruit salad" and thus requires
>> > yet more tweaking to make the text legible again.
>> > - it's unclear that these specific chars are particular sources of errors.
>> > - why not have a more generic name like font-lock-important-detail-face,
>> > so it's at least not so absurdly narrow-scoped.
>>
>> Indeed, I find that it makes my code much harder to read. The choice of
>> a bold face as default is especially bad. And as you say, I don't
>> really think people write !foo erroneously all that often.
>
> Let me join the choir and say that the effect of this change is
> unpleasant at best, IMO. I think this new feature should be at least
> turned off by default, if not removed.
And it makes wrong highlights too, e.g. the '!' in the following line:
xassert (s != NULL);
When was this new feature discussed?
--
Kim F. Storm <storm@cua.dk> http://www.cua.dk
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: font-lock-negation-char-face
2005-05-07 9:57 ` font-lock-negation-char-face Eli Zaretskii
2005-05-07 20:17 ` font-lock-negation-char-face Kim F. Storm
@ 2005-05-08 9:03 ` Richard Stallman
2005-05-08 10:41 ` font-lock-negation-char-face Paul Pogonyshev
1 sibling, 1 reply; 10+ messages in thread
From: Richard Stallman @ 2005-05-08 9:03 UTC (permalink / raw)
Cc: emacs-devel
I think this feature should be removed now.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2005-05-09 8:57 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-05-06 22:32 font-lock-negation-char-face Stefan Monnier
2005-05-07 6:15 ` font-lock-negation-char-face Henrik Enberg
2005-05-07 9:57 ` font-lock-negation-char-face Eli Zaretskii
2005-05-07 20:17 ` font-lock-negation-char-face Kim F. Storm
2005-05-08 22:40 ` font-lock-negation-char-face Juanma Barranquero
2005-05-08 9:03 ` font-lock-negation-char-face Richard Stallman
2005-05-08 10:41 ` font-lock-negation-char-face Paul Pogonyshev
2005-05-08 17:33 ` font-lock-negation-char-face Stefan Monnier
2005-05-09 8:57 ` font-lock-negation-char-face Richard Stallman
2005-05-08 22:46 ` font-lock-negation-char-face Richard Stallman
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.