From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: shell-command - missing shell-quote-argument for program? Date: Thu, 12 Oct 2006 16:56:18 +0200 Message-ID: References: <452517DC.5010007@student.lu.se> <45251C56.8010603@student.lu.se> <45265833.4030709@student.lu.se> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1160665489 6696 80.91.229.2 (12 Oct 2006 15:04:49 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 12 Oct 2006 15:04:49 +0000 (UTC) Cc: Thomas Link , Emacs Devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 12 17:04:44 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GY1zx-000792-Qy for ged-emacs-devel@m.gmane.org; Thu, 12 Oct 2006 16:57:27 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GY1zx-000883-DT for ged-emacs-devel@m.gmane.org; Thu, 12 Oct 2006 10:57:25 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GY1zj-00087R-AR for emacs-devel@gnu.org; Thu, 12 Oct 2006 10:57:11 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GY1zi-00086V-8Y for emacs-devel@gnu.org; Thu, 12 Oct 2006 10:57:10 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GY1zh-00086O-RU for emacs-devel@gnu.org; Thu, 12 Oct 2006 10:57:09 -0400 Original-Received: from [195.41.46.237] (helo=pfepc.post.tele.dk) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GY27w-0002qR-OQ for emacs-devel@gnu.org; Thu, 12 Oct 2006 11:05:40 -0400 Original-Received: from kfs-l.imdomain.dk.cua.dk (unknown [80.165.4.124]) by pfepc.post.tele.dk (Postfix) with SMTP id AFC238A000E; Thu, 12 Oct 2006 16:57:04 +0200 (CEST) Original-To: Lennart Borgman In-Reply-To: <45265833.4030709@student.lu.se> (Lennart Borgman's message of "Fri\, 06 Oct 2006 15\:20\:51 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:60670 Archived-At: Lennart Borgman writes: > The author of filesets Thomas Link has replied to me that he currently > does not use Emacs and cannot maintain filesets.el until that situation > changes. > > I myself therefore suggest the following patch to filesets.el: Isolated, it looks ok, but if you look at filesets-quote, maybe it should use shell-quote-argment too, and we should use filesets-quote on buffer-file-name below. But it's too complex for me to follow the logic in filesets. > > Index: filesets.el > =================================================================== > RCS file: /cvsroot/emacs/emacs/lisp/filesets.el,v > retrieving revision 1.29 > diff -c -r1.29 filesets.el > *** filesets.el 13 Aug 2006 17:05:12 -0000 1.29 > --- filesets.el 6 Oct 2006 13:15:12 -0000 > *************** > *** 1701,1707 **** > ok) > t))) > (when ok > ! (let ((cmd (format txt (buffer-file-name)))) > (message "Filesets: %s" cmd) > (filesets-cmd-show-result cmd > (shell-command-to-string cmd)))))) > --- 1701,1707 ---- > ok) > t))) > (when ok > ! (let ((cmd (format txt (shell-quote-argument (buffer-file-name))))) > (message "Filesets: %s" cmd) > (filesets-cmd-show-result cmd > (shell-command-to-string cmd)))))) -- Kim F. Storm http://www.cua.dk