From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.devel Subject: Re: Patch to make VC annotate async Date: Sun, 24 Jun 2007 12:05:33 -0600 Message-ID: References: Reply-To: tromey@redhat.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1182709502 24345 80.91.229.12 (24 Jun 2007 18:25:02 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 24 Jun 2007 18:25:02 +0000 (UTC) Cc: emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 24 20:25:00 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1I2Wlg-000865-Ec for ged-emacs-devel@m.gmane.org; Sun, 24 Jun 2007 20:25:00 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1I2Wlf-0006sE-U3 for ged-emacs-devel@m.gmane.org; Sun, 24 Jun 2007 14:24:59 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1I2Wlc-0006pr-Ai for emacs-devel@gnu.org; Sun, 24 Jun 2007 14:24:56 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1I2Wla-0006pZ-N2 for emacs-devel@gnu.org; Sun, 24 Jun 2007 14:24:55 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1I2Wla-0006pV-Hg for emacs-devel@gnu.org; Sun, 24 Jun 2007 14:24:54 -0400 Original-Received: from mx1.redhat.com ([66.187.233.31]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1I2WlZ-0003lf-CS; Sun, 24 Jun 2007 14:24:53 -0400 Original-Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l5OIOqSU013684; Sun, 24 Jun 2007 14:24:52 -0400 Original-Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l5OIOqiI005722; Sun, 24 Jun 2007 14:24:52 -0400 Original-Received: from opsy.redhat.com (ton.toronto.redhat.com [172.16.14.15]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l5OIOpdP017295; Sun, 24 Jun 2007 14:24:52 -0400 Original-Received: by opsy.redhat.com (Postfix, from userid 500) id D8E86378285; Sun, 24 Jun 2007 12:05:34 -0600 (MDT) X-Attribution: Tom In-Reply-To: (Richard Stallman's message of "Sun\, 24 Jun 2007 13\:35\:04 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.990 (gnu/linux) X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:73765 Archived-At: >>>>> "rms" == Richard Stallman writes: > However, it turns out that changing vc-svn.el to annotate in the > background does not work -- in my test case (a file in GCC), the > annotation is truncated before the end of the file. I'm not sure what > is going on here. rms> This reminds me of other bugs we have seen, and struggled with, over rms> the years. Thus, investigating this is very important. Can you post rms> precisel directions so that others can try to reproduce it? Sure. My current test case is somewhat complicated, unfortunately: * Apply the patch I sent. * Build and install Emacs. * Check out GCC svn trunk. You probably don't need all of it; the test file I use is gcc/c-parser.c. * Run the new Emacs with -q * Visit the test file and "C-x v g" as a test, to make sure it is working correctly. * Eval this redefinition: (defun vc-svn-annotate-command (file buf &optional rev) (vc-svn-command buf 'async file "annotate" (if rev (concat "-r" rev)))) This changes a 0 to 'async. * "C-x v g" again on the test file. For me this reliably cuts off the output at the same place, before the file's end. Tom