all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: rms@gnu.org
Cc: emacs-devel@gnu.org
Subject: Re: Patch to make VC annotate async
Date: Sun, 24 Jun 2007 12:05:33 -0600	[thread overview]
Message-ID: <m3zm2p1b4i.fsf@fleche.redhat.com> (raw)
In-Reply-To: <E1I2VzM-0005jP-Gl@fencepost.gnu.org> (Richard Stallman's message of "Sun\, 24 Jun 2007 13\:35\:04 -0400")

>>>>> "rms" == Richard Stallman <rms@gnu.org> writes:

>     However, it turns out that changing vc-svn.el to annotate in the
>     background does not work -- in my test case (a file in GCC), the
>     annotation is truncated before the end of the file.  I'm not sure what
>     is going on here.

rms> This reminds me of other bugs we have seen, and struggled with, over
rms> the years.  Thus, investigating this is very important.  Can you post
rms> precisel directions so that others can try to reproduce it?

Sure.  My current test case is somewhat complicated, unfortunately:

* Apply the patch I sent.

* Build and install Emacs.

* Check out GCC svn trunk.  You probably don't need all of it; the
  test file I use is gcc/c-parser.c.

* Run the new Emacs with -q

* Visit the test file and "C-x v g" as a test, to make sure it is
  working correctly.

* Eval this redefinition:

(defun vc-svn-annotate-command (file buf &optional rev)
  (vc-svn-command buf 'async file "annotate" (if rev (concat "-r" rev))))

  This changes a 0 to 'async.

* "C-x v g" again on the test file.  For me this reliably cuts off the
  output at the same place, before the file's end.

Tom

  reply	other threads:[~2007-06-24 18:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-24  2:32 Patch to make VC annotate async Tom Tromey
2007-06-24 17:35 ` Richard Stallman
2007-06-24 18:05   ` Tom Tromey [this message]
2007-06-24 23:47     ` Richard Stallman
2007-06-24 19:33 ` Stefan Monnier
2007-06-24 21:32   ` Tom Tromey
2007-06-25  1:34     ` Stefan Monnier
2007-06-25 15:24       ` Tom Tromey
2007-06-25 16:54         ` Stefan Monnier
2007-06-25 17:53           ` Tom Tromey
2007-06-26 17:48       ` Stefan Monnier
2007-07-07 21:06 ` Stefan Monnier
2007-07-09 15:12   ` Tom Tromey
2007-07-09 19:09     ` David Kastrup
2007-07-11 16:02       ` Tom Tromey
2007-07-12  3:15         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3zm2p1b4i.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=emacs-devel@gnu.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.