From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: James Cloos Newsgroups: gmane.emacs.devel Subject: Re: Emacs core TLS support Date: Fri, 13 Aug 2010 07:04:49 -0400 Message-ID: References: <878wc1vfh3.fsf@lifelogs.com> <87r5ptpnz2.fsf@stupidchicken.com> <871vhsvkut.fsf@lifelogs.com> <87d41csktn.fsf@lifelogs.com> <87k4v0n0m8.fsf@lifelogs.com> <87wrrvfnc4.fsf@lifelogs.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1281698349 29819 80.91.229.12 (13 Aug 2010 11:19:09 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 13 Aug 2010 11:19:09 +0000 (UTC) Cc: emacs-devel@gnu.org To: Ted Zlatanov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 13 13:19:08 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OjsHz-0007M7-BZ for ged-emacs-devel@m.gmane.org; Fri, 13 Aug 2010 13:19:07 +0200 Original-Received: from localhost ([127.0.0.1]:59668 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OjsHy-0003A9-Nx for ged-emacs-devel@m.gmane.org; Fri, 13 Aug 2010 07:19:06 -0400 Original-Received: from [140.186.70.92] (port=59346 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OjsHs-00038R-JC for emacs-devel@gnu.org; Fri, 13 Aug 2010 07:19:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OjsHr-0005nu-85 for emacs-devel@gnu.org; Fri, 13 Aug 2010 07:19:00 -0400 Original-Received: from eagle.jhcloos.com ([207.210.242.212]:39056) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OjsHr-0005nk-5I for emacs-devel@gnu.org; Fri, 13 Aug 2010 07:18:59 -0400 Original-Received: by eagle.jhcloos.com (Postfix, from userid 10) id 0FA0D40314; Fri, 13 Aug 2010 11:18:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jhcloos.com; s=eagle; t=1281698337; bh=kWTy9dlYVHvO1b55pGFbHo5STy4nk5C9CGHv89pbWuI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=coljJ9KdpnZRdNPp/H3G+RA2FxN2sipgzyKHLIxKCM9pHRIkwlqUiORW1R9QOnu+q +b/9He8FQJdgDnJWNe1N4/yyixmJSQDB/QbuCpa1NesdKdSrncl7FAejTZQYOaqewx 8TBPGfuOlPwx8dnVIQYyWppsvnBPmH1rNwooP9EE= Original-Received: from carbon.jhcloos.org (localhost [127.0.0.1]) by carbon.jhcloos.org (Postfix) with ESMTP id 8A6221D2858; Fri, 13 Aug 2010 11:04:49 +0000 (UTC) In-Reply-To: <87wrrvfnc4.fsf@lifelogs.com> (Ted Zlatanov's message of "Thu, 12 Aug 2010 18:00:43 -0500") User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAABHNCSVQICAgIfAhkiAAAAI1J REFUOE+lU9ESgCAIg64P1y+ngUdxhl5H8wFbbM0OmUiEhKkCYaZThXCo6KE5sCbA1DDX3genvO4d eBQgEMaM5qy6uWk4SfBYfdu9jvBN9nSVDOKRtwb+I3epboOsOX5pZbJNsBJFvmQQ05YMfieIBnYX FK2N6dOawd97r/e8RjkTLzmMsiVgrAoEugtviCM3v2WzjgAAAABJRU5ErkJggg== Copyright: Copyright 2009 James Cloos OpenPGP: ED7DAEA6; url=http://jhcloos.com/public_key/0xED7DAEA6.asc OpenPGP-Fingerprint: E9E9 F828 61A4 6EA9 0F2B 63E7 997A 9F17 ED7D AEA6 Original-Lines: 28 X-Hashcash: 1:30:100813:tzz@lifelogs.com::zbiWIvY6UUKAMyFV:Ayaf4 X-Hashcash: 1:30:100813:emacs-devel@gnu.org::lPFgO5BV0Ae3ApgI:00000000000000000000000000000000000000000Yg+Pd X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:128598 Archived-At: I'm just scanning though the patch for now, but the first think I notice is that it needs to be updated from k&r to ansi. An example: +int +emacs_gnutls_write (fildes, state, buf, nbyte) + int fildes; + gnutls_session_t state; + char *buf; + unsigned int nbyte; +{ + register int rtnval, bytes_written; should be changed to: +int +emacs_gnutls_write (int fildes, gnutls_session_t state, char *buf, unsigned int nbyte) +{ + register int rtnval, bytes_written; As so for the rest of the new C functions. (Having written that, I don't remember whether the 23 branch was also updated from k&r; so the above may only apply if it is meant just for trunk.) -JimC -- James Cloos OpenPGP: 1024D/ED7DAEA6