* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r103740: Remove some files that autoreconf can supply.
2011-03-25 17:13 ` Glenn Morris
@ 2011-03-25 17:27 ` Óscar Fuentes
2011-03-25 17:54 ` Eli Zaretskii
2011-03-25 21:21 ` Stefan Monnier
2 siblings, 0 replies; 9+ messages in thread
From: Óscar Fuentes @ 2011-03-25 17:27 UTC (permalink / raw)
To: Glenn Morris; +Cc: Stefan Monnier, emacs-devel
Glenn Morris <rgm@gnu.org> writes:
> Stefan Monnier wrote:
>
>> The above is bad. Never ever do "add+remove" instead of "bzr mv".
>[snip]
>
> I understand this point, but these are "generated" (sort of...) files.
> The history is not important.
[snip]
Apart from preserving history, there is another reason for using `bzr
mv' instead of plain `mv': the latter requires storing again the file
contents into the database, while the former represents the operation in
a very efficient way, which saves storage and network traffic.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r103740: Remove some files that autoreconf can supply.
2011-03-25 17:13 ` Glenn Morris
2011-03-25 17:27 ` Óscar Fuentes
@ 2011-03-25 17:54 ` Eli Zaretskii
2011-03-25 18:13 ` Glenn Morris
2011-03-25 21:21 ` Stefan Monnier
2 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2011-03-25 17:54 UTC (permalink / raw)
To: Glenn Morris; +Cc: monnier, emacs-devel
> From: Glenn Morris <rgm@gnu.org>
> Date: Fri, 25 Mar 2011 13:13:13 -0400
> Cc: emacs-devel@gnu.org
>
> I understand this point, but these are "generated" (sort of...) files.
> The history is not important. Indeed, the history has been reset, since
> they are now the versions that automake-1.11 supplies rather than the
> versions that were previously in Emacs. In some sense, they aren't even
> the same files. The "missing" that you use to build Emacs isn't in the
> repo any more. Instead there is a fallback that you can copy into place
> if you really need to. That is why I did not "move" them.
I think at least the history of src/config.in and lib/Makefile.in
should be preserved, since they are affiliated with Emacs (unlike the
other files which are brought from outside). Does anyone object to
restoring the history of these two files?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r103740: Remove some files that autoreconf can supply.
2011-03-25 17:54 ` Eli Zaretskii
@ 2011-03-25 18:13 ` Glenn Morris
2011-03-25 19:38 ` Eli Zaretskii
0 siblings, 1 reply; 9+ messages in thread
From: Glenn Morris @ 2011-03-25 18:13 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: monnier, emacs-devel
Eli Zaretskii wrote:
> I think at least the history of src/config.in and lib/Makefile.in
> should be preserved, since they are affiliated with Emacs (unlike the
> other files which are brought from outside). Does anyone object to
> restoring the history of these two files?
Not at all. Please just do (or I can try to do) it so that we can get on
with other things. Maybe do the others at the same time, then it's done?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r103740: Remove some files that autoreconf can supply.
2011-03-25 18:13 ` Glenn Morris
@ 2011-03-25 19:38 ` Eli Zaretskii
2011-03-25 19:48 ` Glenn Morris
0 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2011-03-25 19:38 UTC (permalink / raw)
To: Glenn Morris; +Cc: monnier, emacs-devel
> From: Glenn Morris <rgm@gnu.org>
> Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
> Date: Fri, 25 Mar 2011 14:13:27 -0400
>
> Eli Zaretskii wrote:
>
> > I think at least the history of src/config.in and lib/Makefile.in
> > should be preserved, since they are affiliated with Emacs (unlike the
> > other files which are brought from outside). Does anyone object to
> > restoring the history of these two files?
>
> Not at all. Please just do (or I can try to do) it so that we can get on
> with other things. Maybe do the others at the same time, then it's done?
Done for all of the files.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r103740: Remove some files that autoreconf can supply.
2011-03-25 17:13 ` Glenn Morris
2011-03-25 17:27 ` Óscar Fuentes
2011-03-25 17:54 ` Eli Zaretskii
@ 2011-03-25 21:21 ` Stefan Monnier
2011-03-26 19:33 ` Tom Tromey
2 siblings, 1 reply; 9+ messages in thread
From: Stefan Monnier @ 2011-03-25 21:21 UTC (permalink / raw)
To: Glenn Morris; +Cc: emacs-devel
>> The above is bad. Never ever do "add+remove" instead of "bzr mv".
>> Please please please. This is not CVS any more. We've been through
>> this so many times already I'm surprised we still see this issue coming
>> back every time we perform such reorganizations.
>> Let's be more careful in the future.
> I understand this point, but these are "generated" (sort of...) files.
Yes, that history is not really important. But we should simply always
use "bzr mv" when it can be used unless there's really a good reason
against it (never came across one, FWIW).
Stefan
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r103740: Remove some files that autoreconf can supply.
2011-03-25 21:21 ` Stefan Monnier
@ 2011-03-26 19:33 ` Tom Tromey
0 siblings, 0 replies; 9+ messages in thread
From: Tom Tromey @ 2011-03-26 19:33 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan> Yes, that history is not really important. But we should simply always
Stefan> use "bzr mv" when it can be used unless there's really a good reason
Stefan> against it (never came across one, FWIW).
It seems like bzr could recognize this case and ask if you intended to
`bzr mv' instead.
Otherwise, I think you just have to assume that people are going to make
this mistake from time to time.
Tom
^ permalink raw reply [flat|nested] 9+ messages in thread