From: Daiki Ueno <ueno@unixuser.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 12193@debbugs.gnu.org, chad <yandros@MIT.EDU>
Subject: bug#12193: 24.1.50; 24.1.50; Completion broken in revno 109116
Date: Tue, 14 Aug 2012 11:50:30 +0900 [thread overview]
Message-ID: <m3zk5y9og9.fsf-ueno@unixuser.org> (raw)
In-Reply-To: <AE989CC9-BD62-4ED1-B88C-A423D8000E11@mit.edu> (chad's message of "Mon, 13 Aug 2012 14:04:47 -0700")
chad <yandros@MIT.EDU> writes:
> I'm still seeing the problem, but my recipe was off. Try this instead:
I can reproduce it and find it quite annoying. There seems to be
another couple of typo in Stefan's with-selected-window cleanup
(r109577):
> +(defun internal--after-with-seleted-window (state)
> + ;; First reset frame-selected-window.
> + (when (window-live-p (nth 2 state))
> + ;; We don't use set-frame-selected-window because it does not
> + ;; pass the `norecord' argument to Fselect_window.
> + (select-window (nth 2 state) 'norecord)
> + (and (frame-live-p (nth 3 state))
> + (not (eq (tty-top-frame) (nth 3 state)))
> + (select-frame (nth 3 state) 'norecord)))
> + ;; Then reset the actual selected-window.
> + (when (window-live-p (nth 2 state))
> + (select-window (nth 2 state) 'norecord)))
The last two (nth 2 state) should be (nth 1 state).
Regards,
--
Daiki Ueno
next prev parent reply other threads:[~2012-08-14 2:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 18:23 bug#12193: 24.1.50; 24.1.50; Completion broken in revno 109116 chad
2012-08-13 19:16 ` Eli Zaretskii
2012-08-13 21:04 ` chad
2012-08-14 2:50 ` Daiki Ueno [this message]
2012-08-14 3:19 ` Daiki Ueno
2012-08-14 3:29 ` chad
2012-08-14 15:41 ` Eli Zaretskii
2012-08-14 15:59 ` chad
2012-08-14 4:37 ` Chong Yidong
2012-08-14 2:50 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3zk5y9og9.fsf-ueno@unixuser.org \
--to=ueno@unixuser.org \
--cc=12193@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=yandros@MIT.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.