From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: joakim@verona.se Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets Date: Tue, 10 Feb 2015 19:27:09 +0100 Message-ID: References: <20150201003025.18138.95966@vcs.savannah.gnu.org> <54CDC38C.9080701@yandex.ru> <54CE05A0.2090701@cs.ucla.edu> <54D15CF5.3020809@cs.ucla.edu> <54D2BB6E.1040704@cs.ucla.edu> <54D90EE4.1000808@cs.ucla.edu> <54D932A9.1020004@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1423593186 29379 80.91.229.3 (10 Feb 2015 18:33:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 10 Feb 2015 18:33:06 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 10 19:32:56 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YLFcG-0001ls-Go for ged-emacs-devel@m.gmane.org; Tue, 10 Feb 2015 19:32:56 +0100 Original-Received: from localhost ([::1]:41258 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLFcF-0005M1-Vt for ged-emacs-devel@m.gmane.org; Tue, 10 Feb 2015 13:32:55 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36701) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLFX9-0004L9-9R for emacs-devel@gnu.org; Tue, 10 Feb 2015 13:27:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLFX4-0002u6-7F for emacs-devel@gnu.org; Tue, 10 Feb 2015 13:27:39 -0500 Original-Received: from mx2.bahnhof.se ([213.80.101.12]:52645) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLFX4-0002tW-1U for emacs-devel@gnu.org; Tue, 10 Feb 2015 13:27:34 -0500 Original-Received: from localhost (mf.bahnhof.se [213.80.101.20]) by mx2-reinject (Postfix) with ESMTP id 9DF8B4086F; Tue, 10 Feb 2015 19:27:31 +0100 (CET) X-Virus-Scanned: by amavisd-new using ClamAV at bahnhof.se (MF4) Original-Received: from mf4.bahnhof.se ([127.0.0.1]) by localhost (mf4.bahnhof.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gZmD-Z7Ln0FA; Tue, 10 Feb 2015 19:27:26 +0100 (CET) Original-Received: from mta.verona.se (h-235-62.a149.priv.bahnhof.se [85.24.235.62]) by mf4.bahnhof.se (Postfix) with ESMTP id 1C4D23D7873; Tue, 10 Feb 2015 19:27:25 +0100 (CET) Original-Received: from localhost (unknown [127.0.0.1]) by mta.verona.se (Postfix) with ESMTP id A4B5A52C151; Tue, 10 Feb 2015 18:27:25 +0000 (UTC) X-Virus-Scanned: amavisd-new at verona.se Original-Received: from mta.verona.se ([127.0.0.1]) by localhost (exodia.verona.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3s0LlpwKf7lk; Tue, 10 Feb 2015 19:27:09 +0100 (CET) Original-Received: from exodia.verona.se (www.verona.se [192.168.200.15]) by mta.verona.se (Postfix) with ESMTP id 73BEC52C14D; Tue, 10 Feb 2015 19:27:09 +0100 (CET) In-Reply-To: <54D932A9.1020004@cs.ucla.edu> (Paul Eggert's message of "Mon, 09 Feb 2015 14:20:25 -0800") User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 213.80.101.12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:182828 Archived-At: Paul Eggert writes: > On 02/09/2015 12:24 PM, joakim@verona.se wrote: >> My concern was that I have made no changees AFAIK to coding.c. So how >> did it wind up in the patch you provided? > > I don't recall, but let's not worry about it. > >> >>>> >>And these: >>>> >>- next_element_from_stretch >>>> >>+ next_element_from_stretch, >>>> >> #ifdef HAVE_XWIDGETS >>>> >>- ,next_element_from_xwidget >>>> >>+ next_element_from_xwidget, >>>> >> >>>> >>is it really correct to move the coma out of the ifdef? >>> > >>> >Yes, in C99, which Emacs is now assuming. >> It feels weird, but well okay then. And its really considered better >> form? >> > > I prefer it, because it lets one put #if/#endif brackets around any > enum value without worrying about whether the value is listed first or > last or in the middle. The style with leading "," is less consistent, > in that it cannot be used with the first enum value. > Ok, I have applied most of the ideas in you patch now, in the xwidget_mvp branch. I might have missed something, but I think everything is done. -- Joakim Verona