From: storm@cua.dk (Kim F. Storm)
Cc: Nick Roberts <nickrob@snap.net.nz>,
Romain Francoise <romain@orebokech.com>,
emacs-devel@gnu.org
Subject: Re: C-g crash redux
Date: Fri, 04 Aug 2006 13:12:29 +0200 [thread overview]
Message-ID: <m3y7u4sqjm.fsf@kfs-l.imdomain.dk> (raw)
In-Reply-To: <87zmelfihg.fsf@stupidchicken.com> (Chong Yidong's message of "Thu, 03 Aug 2006 20:32:43 -0400")
Chong Yidong <cyd@stupidchicken.com> writes:
>> But how do we ensure that waiting_for_user_input_p is restored
>> correctly on C-g?
>>
>> Or isn't that necessary?
>
> That's not necessary, since quit_throw_to_read_char calls
> clear_waiting_for_input, which resets waiting_for_input to 0.
But it doesn't restore waiting_for_user_input_p to its
previous/original value.
Pls. see the comment about waiting_for_user_input_p in process.c.
>
> I guess someone worked all this out at some time in the past. I added
> a comment to the code to clarify this.
I'm not sure someone worked this out originally.
IIRC, the save/restore of waiting_for_user_input_p was added by
myself, and I doubt it was a concious decision at that time to use the
stack rather than unwind protect.
--
Kim F. Storm <storm@cua.dk> http://www.cua.dk
next prev parent reply other threads:[~2006-08-04 11:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-02 20:50 C-g crash redux Romain Francoise
2006-08-02 22:07 ` Nick Roberts
2006-08-02 23:21 ` Kim F. Storm
2006-08-03 2:40 ` Nick Roberts
2006-08-03 15:13 ` Chong Yidong
2006-08-03 22:29 ` Kim F. Storm
2006-08-04 0:32 ` Chong Yidong
2006-08-04 1:49 ` Nick Roberts
2006-08-04 11:12 ` Kim F. Storm [this message]
2006-08-04 15:26 ` Chong Yidong
2006-08-04 16:03 ` Chong Yidong
2006-08-04 20:59 ` Richard Stallman
2006-08-04 22:07 ` Nick Roberts
2006-08-04 23:35 ` Kim F. Storm
2006-08-05 5:45 ` David Kastrup
2006-08-06 18:28 ` Richard Stallman
2006-08-06 20:58 ` Nick Roberts
2006-08-04 0:59 ` Nick Roberts
2006-08-03 4:16 ` Chong Yidong
2006-08-03 5:40 ` Nick Roberts
2006-08-03 7:17 ` Romain Francoise
2006-08-03 7:35 ` Stefan Monnier
2006-08-03 19:15 ` Richard Stallman
2006-08-03 19:14 ` Richard Stallman
2006-08-03 15:50 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3y7u4sqjm.fsf@kfs-l.imdomain.dk \
--to=storm@cua.dk \
--cc=emacs-devel@gnu.org \
--cc=nickrob@snap.net.nz \
--cc=romain@orebokech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.