From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: busyloop in sigchld_handler Date: Wed, 28 Mar 2007 17:33:05 +0200 Message-ID: References: <87slbpo0pk.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1175096066 15952 80.91.229.12 (28 Mar 2007 15:34:26 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 28 Mar 2007 15:34:26 +0000 (UTC) Cc: Chong Yidong , emacs-devel@gnu.org To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 28 17:34:09 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HWaA1-0001Rz-Vn for ged-emacs-devel@m.gmane.org; Wed, 28 Mar 2007 17:34:06 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HWaCV-00017s-Dp for ged-emacs-devel@m.gmane.org; Wed, 28 Mar 2007 10:36:39 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HWaCR-00016R-Ps for emacs-devel@gnu.org; Wed, 28 Mar 2007 11:36:35 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HWaCO-000152-10 for emacs-devel@gnu.org; Wed, 28 Mar 2007 11:36:34 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HWaCN-00014q-PW for emacs-devel@gnu.org; Wed, 28 Mar 2007 10:36:31 -0500 Original-Received: from pfepc.post.tele.dk ([195.41.46.237]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HWa9t-0001SF-Ed for emacs-devel@gnu.org; Wed, 28 Mar 2007 11:33:57 -0400 Original-Received: from kfs-l.imdomain.dk.cua.dk (unknown [80.165.4.124]) by pfepc.post.tele.dk (Postfix) with SMTP id 7E94A8A001F; Wed, 28 Mar 2007 17:33:55 +0200 (CEST) In-Reply-To: (Andreas Schwab's message of "Wed\, 28 Mar 2007 17\:25\:08 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.96 (gnu/linux) X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:68716 Archived-At: Andreas Schwab writes: > We should probably just remove the loop altogether. The problem is not the loop, but that the first wait3 will take "forever" without the preceding sleep. Nobody have yet explained why. > > --- process.c 28 M=C3=A4r 2007 12:54:58 +0200 1.508 > +++ process.c 28 M=C3=A4r 2007 16:19:54 +0200=09 > @@ -6499,18 +6499,7 @@ sigchld_handler (signo) > #ifndef WUNTRACED > #define WUNTRACED 0 > #endif /* no WUNTRACED */ > - /* Keep trying to get a status until we get a definitive result. = */ > - do > - { > - /* For some reason, this sleep() prevents Emacs from sending > - loadavg to 5-8(!) for ~10 seconds. > - See http://thread.gmane.org/gmane.emacs.devel/67722 or > - http://www.google.com/search?q=3Dbusyloop+in+sigchld_handle= r */ > - usleep (1000); > - errno =3D 0; > - pid =3D wait3 (&w, WNOHANG | WUNTRACED, 0); > - } > - while (pid < 0 && errno =3D=3D EINTR); > + pid =3D wait3 (&w, WNOHANG | WUNTRACED, 0); >=20=20 > if (pid <=3D 0) > { > > Andreas. > > --=20 > Andreas Schwab, SuSE Labs, schwab@suse.de > SuSE Linux Products GmbH, Maxfeldstra=C3=9Fe 5, 90409 N=C3=BCrnberg, Germ= any > PGP key fingerprint =3D 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 > "And now for something completely different." > > --=20 Kim F. Storm http://www.cua.dk