bug#1525: prompt string for execute-extended-command not flexible

bug#1525: prompt string for execute-extended-command not flexible

[xah lee]

The prompt string for execute-extended-command is “M-x ”, but that  
is not correct if the command is bound to some other key by  
customization.

Kevin Rodgers gave this explanation recently in “gnu.emacs.help”:

«
seber...@spawar.navy.mil wrote:
 > When you type a command in Emacs you are greeted with the prompt "M-
 > x".  How change that prompt string?

Change this code in src/keyboard.c and recompile emacs:
    /* This isn't strictly correct if execute-extended-command
       is bound to anything else.  Perhaps it should use
       this_command_keys?  */
    strcat (buf, "M-x ");
-- 
Kevin Rodgers
»

So, possibly the promp can be changed to “Execute command ”.

Thanks.

   Xah
∑ http://xahlee.org/

☄

bug#1525: prompt string for execute-extended-command not flexible

[Lars Magne Ingebrigtsen]

xah lee <xah@xahlee.org> writes:

> The prompt string for execute-extended-command is “M-x ”, but that is
> not correct if the command is bound to some other key by
> customization.
>
> Kevin Rodgers gave this explanation recently in “gnu.emacs.help”:
>
> «
> seber...@spawar.navy.mil wrote:
>> When you type a command in Emacs you are greeted with the prompt "M-
>> x".  How change that prompt string?
>
> Change this code in src/keyboard.c and recompile emacs:
>    /* This isn't strictly correct if execute-extended-command
>       is bound to anything else.  Perhaps it should use
>       this_command_keys?  */
>    strcat (buf, "M-x ");

This is no longer done, but it's still not quite right.

If you do:

(local-set-key [(meta z)] 'execute-extended-command)

Then you still get "M-x" as the prompt if you do `M-z'.

The reason is that it looks up the command first, and then picks one of
the bindings as the description, with code that's kinda like this:

(key-description (car (where-is-internal 'execute-extended-command)))

Is there any reason it doesn't just use this_command_keys which
presumably would be more correct?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#1525: prompt string for execute-extended-command not flexible

[Chong Yidong]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> (local-set-key [(meta z)] 'execute-extended-command)
>
> Then you still get "M-x" as the prompt if you do `M-z'.
>
> The reason is that it looks up the command first, and then picks one of
> the bindings as the description, with code that's kinda like this:
>
> (key-description (car (where-is-internal 'execute-extended-command)))
>
> Is there any reason it doesn't just use this_command_keys which
> presumably would be more correct?

OTOH, you might get into a tricky situation if execute-extended-command
was launched by, say, a mouse event.

bug#1525: prompt string for execute-extended-command not flexible

[Stefan Monnier]

> (key-description (car (where-is-internal 'execute-extended-command)))
> Is there any reason it doesn't just use this_command_keys which
> presumably would be more correct?

Actually the problem is that it should never have said "M-x " but rather
"Run command: ".  From this viewpoint, there's no need to use
this_command_keys: "M-x" is really only meant to be "the canonical
key-binding for this command", so (key-description (car
(where-is-internal 'execute-extended-command))) works as well.
Otherwise if someone happens to hit the "menu" key without realizing
that it's bound to execute-extended-command he might start wonder "OK
the menu bar says 'menu ' what do I do now?", whereas presumably with
"M-x " the user sees "oh that runs the same command as M-x, cool".


        Stefan

bug#1525: prompt string for execute-extended-command not flexible

[Lars Magne Ingebrigtsen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Actually the problem is that it should never have said "M-x " but rather
> "Run command: ".  From this viewpoint, there's no need to use
> this_command_keys: "M-x" is really only meant to be "the canonical
> key-binding for this command", so (key-description (car
> (where-is-internal 'execute-extended-command))) works as well.
> Otherwise if someone happens to hit the "menu" key without realizing
> that it's bound to execute-extended-command he might start wonder "OK
> the menu bar says 'menu ' what do I do now?", whereas presumably with
> "M-x " the user sees "oh that runs the same command as M-x, cool".

Right.  So I'm closing this report, since this isn't really a bug.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/