From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: joakim@verona.se Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets Date: Mon, 09 Feb 2015 12:56:23 +0100 Message-ID: References: <20150201003025.18138.95966@vcs.savannah.gnu.org> <54CDC38C.9080701@yandex.ru> <54CE05A0.2090701@cs.ucla.edu> <54D15CF5.3020809@cs.ucla.edu> <54D2BB6E.1040704@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1423483037 5013 80.91.229.3 (9 Feb 2015 11:57:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 9 Feb 2015 11:57:17 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 09 12:57:17 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YKmxo-0005Ht-4B for ged-emacs-devel@m.gmane.org; Mon, 09 Feb 2015 12:57:16 +0100 Original-Received: from localhost ([::1]:60463 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKmxn-0008PG-JQ for ged-emacs-devel@m.gmane.org; Mon, 09 Feb 2015 06:57:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKmxW-0008OK-5F for emacs-devel@gnu.org; Mon, 09 Feb 2015 06:56:59 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YKmxS-0004yf-Uc for emacs-devel@gnu.org; Mon, 09 Feb 2015 06:56:58 -0500 Original-Received: from mx6.bahnhof.se ([213.80.101.16]:50605) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKmxS-0004yU-OW for emacs-devel@gnu.org; Mon, 09 Feb 2015 06:56:54 -0500 Original-Received: from localhost (mf.bahnhof.se [213.80.101.20]) by mx6-reinject (Postfix) with ESMTP id 686684175C; Mon, 9 Feb 2015 12:56:53 +0100 (CET) X-Virus-Scanned: by amavisd-new using ClamAV at bahnhof.se (MF4) Original-Received: from mf4.bahnhof.se ([127.0.0.1]) by localhost (mf4.bahnhof.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ynFYhyCKj995; Mon, 9 Feb 2015 12:56:46 +0100 (CET) Original-Received: from mta.verona.se (h-235-62.a149.priv.bahnhof.se [85.24.235.62]) by mf4.bahnhof.se (Postfix) with ESMTP id 215043D7889; Mon, 9 Feb 2015 12:56:45 +0100 (CET) Original-Received: from localhost (unknown [127.0.0.1]) by mta.verona.se (Postfix) with ESMTP id AE85452BD78; Mon, 9 Feb 2015 11:56:45 +0000 (UTC) X-Virus-Scanned: amavisd-new at verona.se Original-Received: from mta.verona.se ([127.0.0.1]) by localhost (exodia.verona.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HwLizvulsNAg; Mon, 9 Feb 2015 12:56:24 +0100 (CET) Original-Received: from exodia.verona.se (www.verona.se [192.168.200.15]) by mta.verona.se (Postfix) with ESMTP id 4024E52BD6F; Mon, 9 Feb 2015 12:56:24 +0100 (CET) In-Reply-To: <54D2BB6E.1040704@cs.ucla.edu> (Paul Eggert's message of "Wed, 04 Feb 2015 16:38:06 -0800") User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 213.80.101.16 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:182677 Archived-At: Paul Eggert writes: > joakim@verona.se wrote: >> I'm guessing gnu indent breaks some Emacs build macrology. > > Yes, GNU indent doesn't understand DEFUN or DEFVAR_LISP. Those, you > need to reindent by hand. Please see the patch in my earlier message > for a good style for doing that, at: > > http://lists.gnu.org/archive/html/emacs-devel/2015-02/msg00012.html > > That patch also contains several other ideas worth considering. If > you don't understand any part of that patch please ask. > I'm working through the patch, but its a bit slow going. There seemed to be some spurious diffs: --- a/src/coding.c +++ b/src/coding.c @@ -5985,7 +5985,7 @@ bool raw_text_coding_system_p (struct coding_system *coding) { return (coding->decoder == decode_coding_raw_text - && coding->encoder == encode_coding_raw_text) ? true : false; + && coding->encoder == encode_coding_raw_text); } And these: - next_element_from_stretch + next_element_from_stretch, #ifdef HAVE_XWIDGETS - ,next_element_from_xwidget + next_element_from_xwidget, is it really correct to move the coma out of the ifdef? I remember having trouble with that when I wrote the code originally. My latest patch is in the xwidget_mvp branch, -- Joakim Verona