message-mode completion broken

message-mode completion broken

[Eric Abrahamsen]

Hi,

Since the recent change to message-mode and EUDC, message-mode
completion fails. I noticed this with EBDB, and there's been a report on
gnus.general that BBDB fails as well.

completion-at-point-functions looks like:

(eudc-capf-complete message-completion-function t)

eudc-capf-complete produces "No matches", and
message-completion-function never gets called.

Hope this can be fixed!

Thanks,
Eric

Re: message-mode completion broken

[Dirk-Jan C. Binnema]

On Tuesday Nov 15 2022, Eric Abrahamsen wrote:

> Hi,
>
> Since the recent change to message-mode and EUDC, message-mode
> completion fails. I noticed this with EBDB, and there's been a report on
> gnus.general that BBDB fails as well.
>
> completion-at-point-functions looks like:
>
> (eudc-capf-complete message-completion-function t)
>
> eudc-capf-complete produces "No matches", and
> message-completion-function never gets called.

We ran into that same problems with mu4e's completion:
  https://github.com/djcb/mu/issues/2363

Kind regards,
Dirk.

-- 
Dirk-Jan C. Binnema                  Helsinki, Finland
e:djcb@djcbsoftware.nl           w:www.djcbsoftware.nl
gpg: 6987 9CED 1745 9375 0F14 DA98 11DD FEA9 DCC4 A036

Re: message-mode completion broken

[Robert Pluim]

>>>>> On Wed, 16 Nov 2022 10:16:57 +0200, "Dirk-Jan C. Binnema" <djcb.bulk@gmail.com> said:

    Dirk-Jan> On Tuesday Nov 15 2022, Eric Abrahamsen wrote:

    >> Hi,
    >> 
    >> Since the recent change to message-mode and EUDC, message-mode
    >> completion fails. I noticed this with EBDB, and there's been a report on
    >> gnus.general that BBDB fails as well.
    >> 
    >> completion-at-point-functions looks like:
    >> 
    >> (eudc-capf-complete message-completion-function t)
    >> 
    >> eudc-capf-complete produces "No matches", and
    >> message-completion-function never gets called.

    Dirk-Jan> We ran into that same problems with mu4e's completion:
    Dirk-Jan>   https://github.com/djcb/mu/issues/2363

Please report this as a bug with M-x report-emacs-bug

Robert
-- 

Re: message-mode completion broken

[Eli Zaretskii]

> From: Robert Pluim <rpluim@gmail.com>
> Cc: emacs-devel@gnu.org, Eric Abrahamsen <eric@ericabrahamsen.net>
> Date: Wed, 16 Nov 2022 11:02:04 +0100
> 
> >>>>> On Wed, 16 Nov 2022 10:16:57 +0200, "Dirk-Jan C. Binnema" <djcb.bulk@gmail.com> said:
> 
>     Dirk-Jan> On Tuesday Nov 15 2022, Eric Abrahamsen wrote:
> 
>     >> Hi,
>     >> 
>     >> Since the recent change to message-mode and EUDC, message-mode
>     >> completion fails. I noticed this with EBDB, and there's been a report on
>     >> gnus.general that BBDB fails as well.
>     >> 
>     >> completion-at-point-functions looks like:
>     >> 
>     >> (eudc-capf-complete message-completion-function t)
>     >> 
>     >> eudc-capf-complete produces "No matches", and
>     >> message-completion-function never gets called.
> 
>     Dirk-Jan> We ran into that same problems with mu4e's completion:
>     Dirk-Jan>   https://github.com/djcb/mu/issues/2363
> 
> Please report this as a bug with M-x report-emacs-bug

Yes, and preferably with a recipe that doesn't require 3rd-party
packages to reproduce the problems.

TIA

Re: message-mode completion broken

[Thomas Fitzsimmons]

Hi Eric,

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Since the recent change to message-mode and EUDC, message-mode
> completion fails. I noticed this with EBDB, and there's been a report on
> gnus.general that BBDB fails as well.

Thanks for reporting.

> completion-at-point-functions looks like:
>
> (eudc-capf-complete message-completion-function t)
>
> eudc-capf-complete produces "No matches", and
> message-completion-function never gets called.

As a test, instead of pressing TAB where you're doing the completion,
can you try "C-u M-x eudc-expand-try-all" and see if that recovers the
completion behaviour?

(I wasn't intending to modify default behaviour when I pushed
0e25a39e69acca0324c326ea8e46b1725594bff5 but that's the first patch to
check for any regressions.)

Thanks,
Thomas

Re: message-mode completion broken

[Eric Abrahamsen]

Thomas Fitzsimmons <fitzsim@fitzsim.org> writes:

> Hi Eric,
>
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> Since the recent change to message-mode and EUDC, message-mode
>> completion fails. I noticed this with EBDB, and there's been a report on
>> gnus.general that BBDB fails as well.
>
> Thanks for reporting.
>
>> completion-at-point-functions looks like:
>>
>> (eudc-capf-complete message-completion-function t)
>>
>> eudc-capf-complete produces "No matches", and
>> message-completion-function never gets called.
>
> As a test, instead of pressing TAB where you're doing the completion,
> can you try "C-u M-x eudc-expand-try-all" and see if that recovers the
> completion behaviour?
>
> (I wasn't intending to modify default behaviour when I pushed
> 0e25a39e69acca0324c326ea8e46b1725594bff5 but that's the first patch to
> check for any regressions.)

Thanks for chiming in! Robert/Eli are right this should probably be a
bug report, so I'll do that now, though the important thing was getting
your attention :)

I briefly tried "C-u M-x eudc-expand-try-all", with the same results.
I'm going to open this bug report, and then refresh my memory about how
Emacs' completion works...