From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: Last change to process.c breaks fetching pop3 mail (gnus/pop3.el) Date: 03 Jun 2004 13:48:07 +0200 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <20040530160908.436326.FMU25511@nutty-waffle-cone.splode.com> <20040531143416.431708.FMU25511@nutty-waffle-cone.splode.com> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1086263318 14449 80.91.224.253 (3 Jun 2004 11:48:38 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 3 Jun 2004 11:48:38 +0000 (UTC) Cc: friedman@splode.com, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Thu Jun 03 13:48:30 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BVqhy-0000GB-00 for ; Thu, 03 Jun 2004 13:48:30 +0200 Original-Received: from lists.gnu.org ([199.232.76.165]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BVqhy-0005zg-00 for ; Thu, 03 Jun 2004 13:48:30 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BVqiI-00033V-Tg for emacs-devel@quimby.gnus.org; Thu, 03 Jun 2004 07:48:50 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BVqi5-0002ug-C1 for emacs-devel@gnu.org; Thu, 03 Jun 2004 07:48:37 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BVqi2-0002rx-87 for emacs-devel@gnu.org; Thu, 03 Jun 2004 07:48:36 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BVqi2-0002rn-0c for emacs-devel@gnu.org; Thu, 03 Jun 2004 07:48:34 -0400 Original-Received: from [212.88.64.25] (helo=mail-relay.sonofon.dk) by monty-python.gnu.org with smtp (Exim 4.34) id 1BVqhV-0003Zx-B9 for emacs-devel@gnu.org; Thu, 03 Jun 2004 07:48:01 -0400 Original-Received: (qmail 5981 invoked from network); 3 Jun 2004 11:47:58 -0000 Original-Received: from unknown (HELO kfs-l.imdomain.dk.cua.dk) (213.83.150.2) by 0 with SMTP; 3 Jun 2004 11:47:58 -0000 Original-To: rms@gnu.org In-Reply-To: Original-Lines: 37 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:24469 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:24469 Richard Stallman writes: > IIUC, the problem is that a network process' sentinel would like to > be able to differentiate between the case where the connection is > closed because the remote end closed the connection, or because it > was closed by a call to delete-process. > > If that is the issue, we could arrange for delete-process to call the > sentinel in a special way. Perhaps we could have a different state > for connections closed by delete-process. > > Now, to let the sentinel treat network processes and subprocesses > alike, Noah suggests that the sentinel could look to see if the > process' buffer is still alive. > > That is clearly the wrong criterion, since after delete-process the > buffer would often still be alive. > > The string passed to the sentinel is "finished\n" if delete-process > was called; otherwise it is "exited abnormally with code 256". > > That general idea is ok, though using the status symbol would > be a cleaner way to distinguish. Yes. Here, process-status returns `closed' in both cases, while process-exit-status returns 0 after delete-process and 256 for a broken connection. > > But "finished" is the wrong way to decribe delete-process. > "deleted" would be more appropriate. Normally, you would use delete-process to close the connection. So in that aspect "closed" would be better than "deleted".