From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Inefficient code in ispell.el Date: Mon, 06 Jun 2005 14:06:18 +0200 Message-ID: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1118059881 475 80.91.229.2 (6 Jun 2005 12:11:21 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 6 Jun 2005 12:11:21 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 06 14:11:19 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DfGQE-0007a5-4F for ged-emacs-devel@m.gmane.org; Mon, 06 Jun 2005 14:09:39 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DfGWV-000761-CA for ged-emacs-devel@m.gmane.org; Mon, 06 Jun 2005 08:16:07 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DfGVU-0006vV-86 for emacs-devel@gnu.org; Mon, 06 Jun 2005 08:15:04 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DfGVQ-0006tw-Iw for emacs-devel@gnu.org; Mon, 06 Jun 2005 08:15:00 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DfGVO-0006oK-A8 for emacs-devel@gnu.org; Mon, 06 Jun 2005 08:14:58 -0400 Original-Received: from [195.41.46.236] (helo=pfepb.post.tele.dk) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DfGPo-0006z3-Mj for emacs-devel@gnu.org; Mon, 06 Jun 2005 08:09:12 -0400 Original-Received: from kfs-l.imdomain.dk.cua.dk (unknown [80.165.4.124]) by pfepb.post.tele.dk (Postfix) with SMTP id EE1465EE04B; Mon, 6 Jun 2005 14:05:56 +0200 (CEST) Original-To: Ken Stevens User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:38159 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:38159 I noticed the following code in ispell.el (progn (setq key (buffer-substring-no-properties (car (match-data)) (car (cdr (match-data))))) Using match-data like that is VERY inefficient. I suggest using match-string-no-properties instead, or at least match-beginning/match-end. -- Kim F. Storm http://www.cua.dk